Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winding Current Limiter #131

Open
andermi opened this issue Feb 17, 2023 · 1 comment
Open

Winding Current Limiter #131

andermi opened this issue Feb 17, 2023 · 1 comment

Comments

@andermi
Copy link
Collaborator

andermi commented Feb 17, 2023

Make use of the winding current limiter code in WindingCurrentTarget.hpp in the EHPTO plugin by connecting RamPosition to the actual piston position rather than constant 40 inches in ElectroHydraulicPTO.cpp line 222-223

from:
https://github.com/osrf/buoy_sim/blob/0b03fbda0550234850d1aed838b5a3433df38f97/buoy_gazebo/src/ElectroHydraulicPTO/ElectroHydraulicPTO.cpp#L222-L223

to:

this->dataPtr->functor.I_Wind.RamPosition = (2.03 - PistonPos) * buoy_utils::INCHES_PER_METER;

as well as in pc_commands_ros_feedback.cpp and pc_commands_ros_feedback_py.launch.py

and verify changes in plots in experiment_comparison.cpp

@mabelzhang
Copy link
Collaborator

From meeting: Not in backlog but not a priority for immediate next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants