Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of announces in GoBGP RIB per AFI #2749

Open
pavel-odintsov opened this issue Nov 29, 2023 · 4 comments
Open

Limit number of announces in GoBGP RIB per AFI #2749

pavel-odintsov opened this issue Nov 29, 2023 · 4 comments

Comments

@pavel-odintsov
Copy link
Contributor

pavel-odintsov commented Nov 29, 2023

Hello!

I hope you're doing well.

I'm trying to approach one of the pretty curious cases related with limitation on number of BGP Flow Spec announces which may be imposed by remote side.

There is a pretty short list of ISPs which offer BGP Flow Spec to their customers. For security and validation reasons they limit number of BGP Flow Spec announces received by third party by some pretty low number. Let's say 50 and when we reach this number they shutdown BGP Flow Spec session with customer which leads to withdrawal of all announces which caused havoc and exposes networks to DDoS.

I know that option to limit number of announces received from remote peer exists in GoBGP:

max-prefixes = 1000

We're looking to option to implement limit on number of announces GoBGP stores in local RIB.

Our expected behaviour when limit is reached to receive error when we attempt to add prefix:

gobgp global rib add 10.33.0.0/16 -a ipv4

We clearly can implement it from our side but I think it may be beneficial for other customers to have it.

What do you think about it?

@fujita
Copy link
Member

fujita commented Dec 1, 2023

Other BGP implementations support such feature?

@pavel-odintsov
Copy link
Contributor Author

pavel-odintsov commented Dec 1, 2023 via email

@fujita
Copy link
Member

fujita commented Dec 6, 2023

This is maximum number of prefixes that will be accepted from a peer?

@pavel-odintsov
Copy link
Contributor Author

I do not think so. This one is a global number of prefixes per AFI / SAFI in local RIB. I found this conversation and it has some details about exactly this topic: openconfig/public#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants