Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAC validation fails for 96kHz sample rate #12

Open
yyyar opened this issue May 5, 2020 · 0 comments
Open

AAC validation fails for 96kHz sample rate #12

yyyar opened this issue May 5, 2020 · 0 comments

Comments

@yyyar
Copy link

yyyar commented May 5, 2020

The error is: 'invalid sample-rate 0x0' when v.SampleRate == 0 (SampleRateIndex96kHz)

Seems the problem is here:

if v.SampleRate < SampleRateIndex88kHz || v.SampleRate > SampleRateIndex7kHz {
    return errors.Errorf("invalid sample-rate %#x", uint8(v.SampleRate))
}

This condition does not include 'SampleRateIndex96kHz', is there any reason for this?
Seems 96kHz should be a valid sample rate and pass the validation.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant