Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement repositories #495

Open
10 of 17 tasks
7mochi opened this issue Sep 21, 2023 · 4 comments
Open
10 of 17 tasks

refactor: implement repositories #495

7mochi opened this issue Sep 21, 2023 · 4 comments
Assignees
Labels
code quality Something is implemented poorly good first issue Good for newcomers

Comments

@7mochi
Copy link
Contributor

7mochi commented Sep 21, 2023

@7mochi 7mochi added good first issue Good for newcomers code quality Something is implemented poorly labels Sep 21, 2023
@7mochi 7mochi self-assigned this Sep 21, 2023
@NiceAesth
Copy link
Contributor

What is the direction you are going with the repository PRs? I see you changed the branch for them

@7mochi
Copy link
Contributor Author

7mochi commented Sep 21, 2023

What is the direction you are going with the repository PRs? I see you changed the branch for them

I wanted to make another PR with all the repositories implemented nvm

@cmyui
Copy link
Member

cmyui commented Feb 15, 2024

I've created this PR as a reference for breaking up the collections modules, as they may be a bit trickier than usual:

This PR's description breaks down how we might approach players, channels, clans and matches similarly.

@tsunyoku
Copy link
Contributor

just adding a note onto this about us refactoring existing repositories to sqlalchemy core (for query building), any further repos should be made in the same manor (use #632 as a good example of pretty much any usecase you might run into when writing the repos)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Something is implemented poorly good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants