-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable workflow_dispatch and attach debug APK for Android CI #339
base: master
Are you sure you want to change the base?
Conversation
Is there a reason for running the workflow on every push? |
It's already there since I made the workflow to attach artifacts, perhaps I need to restrict on certain path? |
Apologies, I meant to ask about the artifact part. |
If you meant why is it need to be attach with APK artifact, see the issue I referenced. |
I understand why, but I don't understand why the APK artifact must be attached on every push or pull request. |
There's no reason to it, other than being faster way to build the APK and test it right in your phone whether. I can restrict it to only attach when pushing/making PR on specific path, or restrict it at all and only attach if it's triggered by |
I think that would suffice. There may be cases where a commit should not be tested publicly (i.e., incomplete implementation of a feature), so it should be opt-in. |
Then disabling it via commit message could work, such as |
|
Closes #335
Changes to Android CI (
android.yml
):workflow_dispatch