Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export uses $EXPORT_DIR for its temp space, but import uses /tmp #22

Open
jordane opened this issue Mar 22, 2016 · 3 comments · May be fixed by #23
Open

export uses $EXPORT_DIR for its temp space, but import uses /tmp #22

jordane opened this issue Mar 22, 2016 · 3 comments · May be fixed by #23

Comments

@jordane
Copy link

jordane commented Mar 22, 2016

Most systems that have a separate /tmp mounted don't have the disk space in order to properly unpack and import an image in /tmp. The export script doesn't have this because it calls

TARGET=`mktemp -d --tmpdir=${EXPORT_DIR}`

while the import script calls

TARGET=`mktemp -d`

I'd like to change this anti-symmetry by doing one (and only one) of the following:

  1. Change the import script to TARGET=mktemp -d --tmpdir=${EXPORT_DIR}``
  2. Set IMPORT_DIR in common.sh and use that in the import script.

Thoughts?
@ramereth
Copy link
Member

Yes, we should fix that.

@jordane
Copy link
Author

jordane commented Mar 25, 2016

@ramereth I'll generate a PR. Do you have a preference on IMPORT_DIR vs re-using EXPORT_DIR?

@ramereth
Copy link
Member

@jordane let's go with IMPORT_DIR

@jordane jordane linked a pull request Mar 25, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add IMPORT_DIR and use in import script jordane/ganeti-instance-image
2 participants
@ramereth @jordane