Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-listener breaks fs.unwatchFile #23

Open
hayes opened this issue Dec 29, 2014 · 1 comment
Open

async-listener breaks fs.unwatchFile #23

hayes opened this issue Dec 29, 2014 · 1 comment

Comments

@hayes
Copy link
Collaborator

hayes commented Dec 29, 2014

wrapping up the callback for fs.watchFile prevents you from removing that watch handler, since passing in the unwrapped function will not allow you to remove the wrapped handler

@hayes hayes changed the title async-listener breaks fs.unwatchFIle async-listener breaks fs.unwatchFile Dec 29, 2014
@othiym23
Copy link
Owner

This is probably going to take some emitter-listener levels of monkeypatching to work around, although I doubt there's any way it can be more complicated than what I had to do to get .on() working properly with Streams.

Thanks for the report! I'll start thinking about how to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants