Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.Socket 'connect' event is not wrapped #24

Open
rf opened this issue Jan 15, 2015 · 1 comment
Open

net.Socket 'connect' event is not wrapped #24

rf opened this issue Jan 15, 2015 · 1 comment

Comments

@rf
Copy link

rf commented Jan 15, 2015

Here's a failing test on my fork. I'm not sure this is something that can be wrapped without potentially wrapping the whole (Socket) emitter with something like events-intercept.

Tested fails on node v0.10.26 & v0.8.8

cc @sh1mmer @Raynos

@othiym23
Copy link
Owner

This is probably a job for emitter-listener (or it could be events-intercept, if that's significantly simpler). The tricky part is that the performance hit if you wrap every socket would be pretty severe. I'll need to come up with a way to do this in a much more lightweight way.

Thanks for the report! If you get inspired to try to hack around this, let me know, even if the code is incomplete or gross.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants