Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I would like support for localisation #36

Closed
othyn opened this issue Jul 6, 2022 · 4 comments · Fixed by #37
Closed

As a user, I would like support for localisation #36

othyn opened this issue Jul 6, 2022 · 4 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@othyn
Copy link
Owner

othyn commented Jul 6, 2022

As it says on the tin, this would just be the ground work required to start accepting language support PR's as part of #10

@othyn othyn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 6, 2022
@othyn othyn added this to the v1.4.0 milestone Jul 6, 2022
@othyn othyn self-assigned this Jul 6, 2022
@raimeenakshi
Copy link

Hi @othyn to be clear, you just wish to add Localizable.strings file added to your project, or something else?

@othyn
Copy link
Owner Author

othyn commented Jul 9, 2022

@Max-Rai thank you for opening a dialogue on implementing this! 😄

This is the first time for me localising a macOS project, is using Localisable.strings the best approach for this in your opinion? It's the native approach isn't it?

From my limited knowledge on this, I think this is the direction that would be good for this project (given it's the native approach)

I'm in limited contact until late July (25th~ish), just if I don't respond 😄

@raimeenakshi
Copy link

Hi @othyn attaching few resources which are common for all Apple platforms to support Localization. One can go down the rabbit hole on these documentations, depending on how curious they are 😅

@othyn
Copy link
Owner Author

othyn commented Jul 10, 2022

@Max-Rai thanks for those, very interesting reads! From those I also came across:

... now just to find the time to implement it!

@othyn othyn moved this to In Progress in macOS Auto Clicker Jul 11, 2022
@othyn othyn mentioned this issue Jul 11, 2022
6 tasks
@othyn othyn linked a pull request Jul 11, 2022 that will close this issue
6 tasks
@othyn othyn closed this as completed Jul 11, 2022
Repository owner moved this from In Progress to Done in macOS Auto Clicker Jul 11, 2022
@othyn othyn modified the milestones: v1.4.0, v1.3.3 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

2 participants