Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numIncrease, pctIncrease, rolling calculations where dates are missing #14

Open
flaneuse opened this issue Jun 30, 2020 · 1 comment

Comments

@flaneuse
Copy link
Collaborator

image

See outbreak.info/epidemiology?location=ESP&log=false&variable=confirmed_numIncrease&xVariable=date&fixedY=false

  1. For Spain, the two bad values are 4/28 and 5/2 and by my count should be 957.29 and 449.57, instead of -904 and -1828.
    data for the 4/28 value:
    4/25: 3995
    4/26: NA
    4/27: NA
    4/28: 2706
    4/29: NA
    4/30: NA
    5/1: NA

  2. pctIncreases are wrong if a day is skipped. should be infinite % increase, not relative to the previous non-zero day

  3. Consider adding in explicit confirmed=0, dead=0 when values are NA.

@flaneuse
Copy link
Collaborator Author

temp fix from @gkarthik : exlcuded negative numIncrease values from rolling calculations

@gkarthik gkarthik transferred this issue from outbreak-info/outbreak.info Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant