From 7b058e24ff8d06c5782fc0461c32d19fa8e0c811 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Wed, 25 Sep 2024 18:13:28 -0700 Subject: [PATCH] fix memory leak in Bun.shellEscape return value (#14130) --- src/bun.js/api/BunObject.zig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/bun.js/api/BunObject.zig b/src/bun.js/api/BunObject.zig index 12aff1d40d562..488b9dc9f0a5b 100644 --- a/src/bun.js/api/BunObject.zig +++ b/src/bun.js/api/BunObject.zig @@ -435,7 +435,8 @@ pub fn shellEscape( globalThis.throw("String has invalid utf-16: {s}", .{bunstr.byteSlice()}); return .undefined; } - return bun.String.createUTF8(outbuf.items[0..]).toJS(globalThis); + var str = bun.String.createUTF8(outbuf.items[0..]); + return str.transferToJS(globalThis); } return jsval; } @@ -445,7 +446,8 @@ pub fn shellEscape( globalThis.throwOutOfMemory(); return .undefined; }; - return bun.String.createUTF8(outbuf.items[0..]).toJS(globalThis); + var str = bun.String.createUTF8(outbuf.items[0..]); + return str.transferToJS(globalThis); } return jsval;