From 6f6ea0d6f381153561dd9508f5d82a22789d0ad1 Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Thu, 1 Aug 2024 17:49:01 -0700 Subject: [PATCH 1/2] Add -Xclang -fno-c++-static-destructors on Windows (#13014) --- scripts/env.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/env.ps1 b/scripts/env.ps1 index 406c1681693c5..472065da119d5 100755 --- a/scripts/env.ps1 +++ b/scripts/env.ps1 @@ -48,7 +48,7 @@ $CC = "clang-cl" $CXX = "clang-cl" $CFLAGS = '/O2 /Z7 /MT /O2 /Ob2 /DNDEBUG /U_DLL' -$CXXFLAGS = '/O2 /Z7 /MT /O2 /Ob2 /DNDEBUG /U_DLL' +$CXXFLAGS = '/O2 /Z7 /MT /O2 /Ob2 /DNDEBUG /U_DLL -Xclang -fno-c++-static-destructors ' if ($Lto) { $CXXFLAGS += " -fuse-ld=lld -flto -Xclang -emit-llvm-bc" From 0081ab4738cf9a47b3e8911b40eafcb95038a2d6 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Thu, 1 Aug 2024 17:49:43 -0700 Subject: [PATCH 2/2] ci: disable BUN_ENABLE_CRASH_REPORTING (#13013) --- packages/bun-internal-test/src/runner.node.mjs | 2 +- scripts/runner.node.mjs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bun-internal-test/src/runner.node.mjs b/packages/bun-internal-test/src/runner.node.mjs index 65330b07e07a6..d6d76d3205345 100644 --- a/packages/bun-internal-test/src/runner.node.mjs +++ b/packages/bun-internal-test/src/runner.node.mjs @@ -239,7 +239,7 @@ Starting "${testFileName}" GITHUB_ACTIONS: process.env.GITHUB_ACTIONS ?? "true", BUN_DEBUG_QUIET_LOGS: "1", BUN_INSTALL_CACHE_DIR: join(TMPDIR, ".bun-install-cache"), - BUN_ENABLE_CRASH_REPORTING: "1", + BUN_ENABLE_CRASH_REPORTING: "0", [windows ? "TEMP" : "TMPDIR"]: TMPDIR, }, }); diff --git a/scripts/runner.node.mjs b/scripts/runner.node.mjs index 711513436c318..282de4abeafb3 100755 --- a/scripts/runner.node.mjs +++ b/scripts/runner.node.mjs @@ -436,7 +436,7 @@ async function spawnBun(execPath, { args, cwd, timeout, env, stdout, stderr }) { BUN_FEATURE_FLAG_INTERNAL_FOR_TESTING: "1", BUN_DEBUG_QUIET_LOGS: "1", BUN_GARBAGE_COLLECTOR_LEVEL: "1", - BUN_ENABLE_CRASH_REPORTING: "1", + BUN_ENABLE_CRASH_REPORTING: "0", // change this to '1' if https://github.com/oven-sh/bun/issues/13012 is implemented BUN_RUNTIME_TRANSPILER_CACHE_PATH: "0", BUN_INSTALL_CACHE_DIR: tmpdirPath, SHELLOPTS: isWindows ? "igncr" : undefined, // ignore "\r" on Windows