Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Fails to Install Dependencies with Patches Containing Encoded Characters (e.g., %2F) #14592

Closed
Archetipo95 opened this issue Oct 15, 2024 · 3 comments
Labels
bug Something isn't working bun patch old-version Using a very old version of Bun

Comments

@Archetipo95
Copy link

What version of Bun is running?

1.1.29

What platform is your computer?

Darwin 24.0.0 arm64 arm

What steps can reproduce the bug?

Description

When deploying a project on Netlify that uses the Bun dependency manager, the build process fails if the dependencies include patches with encoded characters such as %2F. This issue seems to stem from Netlify's handling of URL-encoded characters within patch URLs, causing the installation process to break.

Steps to Reproduce

Create a Bun-managed project.
Add a dependency with a patch URL containing encoded characters (e.g., %2F).
Deploy the project on Netlify.
Observe the build process failing during the dependency installation phase.

What is the expected behavior?

Netlify should correctly handle and install dependencies with patches that include encoded characters.

What do you see instead?

The build process on Netlify fails, indicating an issue with the handling of encoded characters in the patch URLs.

Additional information

No response

@Archetipo95 Archetipo95 added bug Something isn't working needs triage labels Oct 15, 2024
@nektro nektro added bun install Something that relates to the npm-compatible client and removed needs triage labels Oct 16, 2024
@Archetipo95
Copy link
Author

Currently Netlify is using: bun version 1.1.12

This problem should be fixed in https://bun.sh/blog/bun-v1.1.18

@Archetipo95
Copy link
Author

@nektro if you want to update this issue or close it feel free. Currently netlify is not applying any patch with regardless of the name

@nektro nektro added bun patch old-version Using a very old version of Bun and removed bun install Something that relates to the npm-compatible client labels Oct 18, 2024
@Archetipo95
Copy link
Author

Closing this issue. Netlify next week is going to rollout the lates bun version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bun patch old-version Using a very old version of Bun
Projects
None yet
Development

No branches or pull requests

2 participants