Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsCode debug broken in 1.1.31, works in 1.1.30 #14674

Closed
Jonatthu opened this issue Oct 18, 2024 · 4 comments · Fixed by #14675
Closed

VsCode debug broken in 1.1.31, works in 1.1.30 #14674

Jonatthu opened this issue Oct 18, 2024 · 4 comments · Fixed by #14675
Labels
bug Something isn't working debugger Something to do with `bun --inspect` or the debugger regression

Comments

@Jonatthu
Copy link

What version of Bun is running?

1.1.31

What platform is your computer?

MacOS Darwin 24.0.0 arm64 arm

What steps can reproduce the bug?

Set a breakpoint using vscode bun extension on bun

Just use Bun.serve.

The server work with regular bun run

What is the expected behavior?

That actually the server starts

What do you see instead?

No response

Additional information

No response

@Jonatthu Jonatthu added bug Something isn't working needs triage labels Oct 18, 2024
@Jonatthu Jonatthu changed the title VsCode mac debugg broken in 1.1.31, works in 1.1.30 VsCode mac debug broken in 1.1.31, works in 1.1.30 Oct 18, 2024
@nektro nektro added debugger Something to do with `bun --inspect` or the debugger and removed needs triage labels Oct 18, 2024
@Jarred-Sumner
Copy link
Collaborator

Confirming this seems to be broken. Pressing pause doesn't work. It doesn't resolve breakpoints.

Image

@Jarred-Sumner
Copy link
Collaborator

Potentially related:

 Error: Invalid debug adapter
    at d.p (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2629:95)
    at d.$acceptDAMessage (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2628:17358)
    at T.S (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2459:14840)
    at T.Q (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2459:14606)
    at T.M (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2459:13639)
    at T.L (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2459:12474)
    at $.value (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2459:11169)
    at l.B (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:437:732)
    at l.fire (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:437:949)
    at s.fire (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1120:14822)
    at G.onmessage (vscode-file://vscode-app/Applications/Cursor.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2475:8223)

@Electroid Electroid changed the title VsCode mac debug broken in 1.1.31, works in 1.1.30 VsCode debug broken in 1.1.31, works in 1.1.30 Oct 18, 2024
@nektro
Copy link
Contributor

nektro commented Oct 18, 2024

started not working after bbb41be

@nektro
Copy link
Contributor

nektro commented Oct 18, 2024

looks like diff became JSGlobalObjectDebuggable::create instead BunJSGlobalObjectDebuggable::create.
testing that fix and will PR if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working debugger Something to do with `bun --inspect` or the debugger regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants