From 25e6e69c423a4e311d8fad7bbda255e975609b9f Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Tue, 1 Oct 2024 22:18:45 -0700 Subject: [PATCH] BunProcess: dont use for-loop for isSignalName --- src/bun.js/bindings/BunProcess.cpp | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/bun.js/bindings/BunProcess.cpp b/src/bun.js/bindings/BunProcess.cpp index c707ad2e8c6d1..ce076e0fe58c1 100644 --- a/src/bun.js/bindings/BunProcess.cpp +++ b/src/bun.js/bindings/BunProcess.cpp @@ -683,16 +683,6 @@ static const NeverDestroyed signalNames[] = { MAKE_STATIC_STRING_IMPL("SIGSYS"), }; -bool isSignalName(WTF::String input) -{ - for (auto i = 0; i < std::size(signalNames); i++) { - if (input == signalNames[i]) { - return true; - } - } - return false; -} - static void loadSignalNumberMap() { @@ -788,6 +778,12 @@ static void loadSignalNumberMap() }); } +bool isSignalName(WTF::String input) +{ + loadSignalNumberMap(); + return signalNameToNumberMap->contains(input); +} + #if OS(WINDOWS) extern "C" uv_signal_t* Bun__UVSignalHandle__init(JSC::JSGlobalObject* lexicalGlobalObject, int signalNumber, void (*callback)(uv_signal_t*, int)); extern "C" uv_signal_t* Bun__UVSignalHandle__close(uv_signal_t*);