Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dates missing with historical data? #9

Open
jasonmadigan opened this issue May 4, 2021 · 0 comments
Open

Dates missing with historical data? #9

jasonmadigan opened this issue May 4, 2021 · 0 comments
Labels
needs investigation A potential bug that has to be investigated

Comments

@jasonmadigan
Copy link

Noticed that dates (presumably when markets are closed) are missing from historical data. E.g.:

rates = await exchangeRates()
    .from('2020-01-01').to('2020-12-31')
    .symbols(['USD'])
    .fetch();

{
  '2020-01-02': { USD: 1.1193 }, // <- where is: 2020-01-02
  '2020-01-03': { USD: 1.1147 },
  '2020-01-06': { USD: 1.1194 }, // and 2020-01-05
  '2020-01-07': { USD: 1.1172 },
  '2020-01-08': { USD: 1.1115 },
  '2020-01-09': { USD: 1.111 },
  '2020-01-10': { USD: 1.1091 },
  '2020-01-13': { USD: 1.1126 },
  '2020-01-14': { USD: 1.1115 },
  '2020-01-15': { USD: 1.1142 },
  '2020-01-16': { USD: 1.1169 },
  '2020-01-17': { USD: 1.1108 },
  '2020-01-20': { USD: 1.1085 },
  '2020-01-21': { USD: 1.1115 },
  '2020-01-22': { USD: 1.1088 },
  '2020-01-23': { USD: 1.1091 },
  '2020-01-24': { USD: 1.1035 },
  '2020-01-27': { USD: 1.1025 },
  '2020-01-28': { USD: 1.1005 },
  '2020-01-29': { USD: 1.1001 },
  '2020-01-30': { USD: 1.1029 },
  '2020-01-31': { USD: 1.1052 },
  '2020-02-03': { USD: 1.1066 },
  '2020-02-04': { USD: 1.1048 },
  '2020-02-05': { USD: 1.1023 },
  '2020-02-06': { USD: 1.1003 },
  '2020-02-07': { USD: 1.0969 },
  '2020-02-10': { USD: 1.0951 },
  '2020-02-11': { USD: 1.0901 },
  '2020-02-12': { USD: 1.0914 },
  '2020-02-13': { USD: 1.0867 },
  '2020-02-14': { USD: 1.0842 },
  '2020-02-17': { USD: 1.0835 },
  '2020-02-18': { USD: 1.0816 },
  '2020-02-19': { USD: 1.08 },
  '2020-02-20': { USD: 1.079 },
  '2020-02-21': { USD: 1.0801 },
  '2020-02-24': { USD: 1.0818 },
  '2020-02-25': { USD: 1.084 },
  '2020-02-26': { USD: 1.0875 },
  '2020-02-27': { USD: 1.0964 },
  '2020-02-28': { USD: 1.0977 },
  '2020-03-02': { USD: 1.1122 },
  '2020-03-03': { USD: 1.1117 },
  '2020-03-04': { USD: 1.1125 },
  '2020-03-05': { USD: 1.1187 },
  '2020-03-06': { USD: 1.1336 },
  '2020-03-09': { USD: 1.1456 },
  '2020-03-10': { USD: 1.139 },
  '2020-03-11': { USD: 1.1336 },
  '2020-03-12': { USD: 1.124 },
  '2020-03-13': { USD: 1.1104 },
  '2020-03-16': { USD: 1.1157 },
  '2020-03-17': { USD: 1.0982 },
  '2020-03-18': { USD: 1.0934 },
  '2020-03-19': { USD: 1.0801 },
  '2020-03-20': { USD: 1.0707 },
  '2020-03-23': { USD: 1.0783 },
  '2020-03-24': { USD: 1.0843 },
  '2020-03-25': { USD: 1.0827 },
  '2020-03-26': { USD: 1.0981 },
  '2020-03-27': { USD: 1.0977 },
  '2020-03-30': { USD: 1.1034 },
  '2020-03-31': { USD: 1.0956 },
  '2020-04-01': { USD: 1.0936 },
  '2020-04-02': { USD: 1.0906 },
  '2020-04-03': { USD: 1.0785 },
  '2020-04-06': { USD: 1.0791 },
  '2020-04-07': { USD: 1.0885 },
  '2020-04-08': { USD: 1.0871 },
  '2020-04-09': { USD: 1.0867 },
  '2020-04-14': { USD: 1.0963 },
  '2020-04-15': { USD: 1.0903 },
  '2020-04-16': { USD: 1.0888 },
  '2020-04-17': { USD: 1.086 },
  '2020-04-20': { USD: 1.086 },
  '2020-04-21': { USD: 1.0837 },
  '2020-04-22': { USD: 1.0867 },
  '2020-04-23': { USD: 1.0772 },
  '2020-04-24': { USD: 1.08 },
  '2020-04-27': { USD: 1.0852 },
  '2020-04-28': { USD: 1.0877 },
  '2020-04-29': { USD: 1.0842 },
  '2020-04-30': { USD: 1.0876 },
  '2020-05-04': { USD: 1.0942 },
  '2020-05-05': { USD: 1.0843 },
  '2020-05-06': { USD: 1.0807 },
  '2020-05-07': { USD: 1.0783 },
  '2020-05-08': { USD: 1.0843 },
  '2020-05-11': { USD: 1.0824 },
  '2020-05-12': { USD: 1.0858 },
  '2020-05-13': { USD: 1.0875 },
  '2020-05-14': { USD: 1.0792 },
  '2020-05-15': { USD: 1.0798 },
  '2020-05-18': { USD: 1.0832 },
  '2020-05-19': { USD: 1.095 },
  '2020-05-20': { USD: 1.0958 },
  '2020-05-21': { USD: 1.1 },
  '2020-05-22': { USD: 1.0904 },
  '2020-05-25': { USD: 1.091 },
  '2020-05-26': { USD: 1.0975 },
  '2020-05-27': { USD: 1.0991 },
  '2020-05-28': { USD: 1.1016 },
  '2020-05-29': { USD: 1.1136 },
  '2020-06-01': { USD: 1.1116 },
  '2020-06-02': { USD: 1.1174 },
  '2020-06-03': { USD: 1.1194 },
  '2020-06-04': { USD: 1.125 },
  '2020-06-05': { USD: 1.133 },
  '2020-06-08': { USD: 1.1285 },
  '2020-06-09': { USD: 1.1294 },
  '2020-06-10': { USD: 1.1375 },
  '2020-06-11': { USD: 1.1348 },
  '2020-06-12': { USD: 1.1304 },
  '2020-06-15': { USD: 1.1253 },
  '2020-06-16': { USD: 1.1308 },
  '2020-06-17': { USD: 1.1232 },
  '2020-06-18': { USD: 1.1222 },
  '2020-06-19': { USD: 1.121 },
  '2020-06-22': { USD: 1.1213 },
  '2020-06-23': { USD: 1.1318 },
  '2020-06-24': { USD: 1.128 },
  '2020-06-25': { USD: 1.12 },
  '2020-06-26': { USD: 1.1213 },
  '2020-06-29': { USD: 1.1284 },
  '2020-06-30': { USD: 1.1198 },
  '2020-07-01': { USD: 1.12 },
  '2020-07-02': { USD: 1.1286 },
  '2020-07-03': { USD: 1.1224 },
  '2020-07-06': { USD: 1.1325 },
  '2020-07-07': { USD: 1.129 },
  '2020-07-08': { USD: 1.1286 },
  '2020-07-09': { USD: 1.1342 },
  '2020-07-10': { USD: 1.1276 },
  '2020-07-13': { USD: 1.1329 },
  '2020-07-14': { USD: 1.1375 },
  '2020-07-15': { USD: 1.1444 },
  '2020-07-16': { USD: 1.1414 },
  '2020-07-17': { USD: 1.1428 },
  '2020-07-20': { USD: 1.1448 },
  '2020-07-21': { USD: 1.1443 },
  '2020-07-22': { USD: 1.1578 },
  '2020-07-23': { USD: 1.1569 },
  '2020-07-24': { USD: 1.1608 },
  '2020-07-27': { USD: 1.176 },
  '2020-07-28': { USD: 1.1717 },
  '2020-07-29': { USD: 1.1725 },
  '2020-07-30': { USD: 1.1743 },
  '2020-07-31': { USD: 1.1848 },
  '2020-08-03': { USD: 1.1726 },
  '2020-08-04': { USD: 1.1765 },
  '2020-08-05': { USD: 1.1854 },
  '2020-08-06': { USD: 1.1843 },
  '2020-08-07': { USD: 1.1817 },
  '2020-08-10': { USD: 1.1763 },
  '2020-08-11': { USD: 1.1783 },
  '2020-08-12': { USD: 1.1771 },
  '2020-08-13': { USD: 1.1833 },
  '2020-08-14': { USD: 1.1813 },
  '2020-08-17': { USD: 1.1853 },
  '2020-08-18': { USD: 1.1906 },
  '2020-08-19': { USD: 1.1933 },
  '2020-08-20': { USD: 1.185 },
  '2020-08-21': { USD: 1.1769 },
  '2020-08-24': { USD: 1.1847 },
  '2020-08-25': { USD: 1.1814 },
  '2020-08-26': { USD: 1.1789 },
  '2020-08-27': { USD: 1.1806 },
  '2020-08-28': { USD: 1.1915 },
  '2020-08-31': { USD: 1.194 },
  '2020-09-01': { USD: 1.1987 },
  '2020-09-02': { USD: 1.1861 },
  '2020-09-03': { USD: 1.1813 },
  '2020-09-04': { USD: 1.1842 },
  '2020-09-07': { USD: 1.1824 },
  '2020-09-08': { USD: 1.1785 },
  '2020-09-09': { USD: 1.1773 },
  '2020-09-10': { USD: 1.1849 },
  '2020-09-11': { USD: 1.1854 },
  '2020-09-14': { USD: 1.1876 },
  '2020-09-15': { USD: 1.1892 },
  '2020-09-16': { USD: 1.1869 },
  '2020-09-17': { USD: 1.1797 },
  '2020-09-18': { USD: 1.1833 },
  '2020-09-21': { USD: 1.1787 },
  '2020-09-22': { USD: 1.174 },
  '2020-09-23': { USD: 1.1692 },
  '2020-09-24': { USD: 1.1645 },
  '2020-09-25': { USD: 1.1634 },
  '2020-09-28': { USD: 1.167 },
  '2020-09-29': { USD: 1.1702 },
  '2020-09-30': { USD: 1.1708 },
  '2020-10-01': { USD: 1.1752 },
  '2020-10-02': { USD: 1.173 },
  '2020-10-05': { USD: 1.1768 },
  '2020-10-06': { USD: 1.1795 },
  '2020-10-07': { USD: 1.177 },
  '2020-10-08': { USD: 1.1765 },
  '2020-10-09': { USD: 1.1795 },
  '2020-10-12': { USD: 1.1799 },
  '2020-10-13': { USD: 1.1787 },
  '2020-10-14': { USD: 1.175 },
  '2020-10-15': { USD: 1.1698 },
  '2020-10-16': { USD: 1.1741 },
  '2020-10-19': { USD: 1.1785 },
  '2020-10-20': { USD: 1.181 },
  '2020-10-21': { USD: 1.1852 },
  '2020-10-22': { USD: 1.1821 },
  '2020-10-23': { USD: 1.1856 },
  '2020-10-26': { USD: 1.1819 },
  '2020-10-27': { USD: 1.1832 },
  '2020-10-28': { USD: 1.1727 },
  '2020-10-29': { USD: 1.1704 },
  '2020-10-30': { USD: 1.1698 },
  '2020-11-02': { USD: 1.1652 },
  '2020-11-03': { USD: 1.1702 },
  '2020-11-04': { USD: 1.1721 },
  '2020-11-05': { USD: 1.1855 },
  '2020-11-06': { USD: 1.187 },
  '2020-11-09': { USD: 1.1883 },
  '2020-11-10': { USD: 1.1808 },
  '2020-11-11': { USD: 1.1766 },
  '2020-11-12': { USD: 1.1791 },
  '2020-11-13': { USD: 1.1815 },
  '2020-11-16': { USD: 1.183 },
  '2020-11-17': { USD: 1.1882 },
  '2020-11-18': { USD: 1.1868 },
  '2020-11-19': { USD: 1.1832 },
  '2020-11-20': { USD: 1.1863 },
  '2020-11-23': { USD: 1.1901 },
  '2020-11-24': { USD: 1.1865 },
  '2020-11-25': { USD: 1.189 },
  '2020-11-26': { USD: 1.19 },
  '2020-11-27': { USD: 1.1922 },
  '2020-11-30': { USD: 1.198 },
  '2020-12-01': { USD: 1.1968 },
  '2020-12-02': { USD: 1.2066 },
  '2020-12-03': { USD: 1.2151 },
  '2020-12-04': { USD: 1.2159 },
  '2020-12-07': { USD: 1.2128 },
  '2020-12-08': { USD: 1.2114 },
  '2020-12-09': { USD: 1.2109 },
  '2020-12-10': { USD: 1.2115 },
  '2020-12-11': { USD: 1.2127 },
  '2020-12-14': { USD: 1.2162 },
  '2020-12-15': { USD: 1.214 },
  '2020-12-16': { USD: 1.2189 },
  '2020-12-17': { USD: 1.2246 },
  '2020-12-18': { USD: 1.2259 },
  '2020-12-21': { USD: 1.2173 },
  '2020-12-22': { USD: 1.2239 },
  '2020-12-23': { USD: 1.2166 },
  '2020-12-24': { USD: 1.2193 },
  '2020-12-28': { USD: 1.2219 },
  '2020-12-29': { USD: 1.2259 },
  '2020-12-30': { USD: 1.2281 },
  '2020-12-31': { USD: 1.2271 }
}

There is data there for the days in question (e.g. https://api.ratesapi.io/api/2020-01-01), so unsure if this is a bug or some sort of undocumented behaviour.
@over-engineer over-engineer added the needs investigation A potential bug that has to be investigated label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation A potential bug that has to be investigated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonmadigan @over-engineer