Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ICGC Object Storage Configuration from Codebase #846

Open
Azher2Ali opened this issue Aug 19, 2024 · 1 comment
Open

Remove ICGC Object Storage Configuration from Codebase #846

Azher2Ali opened this issue Aug 19, 2024 · 1 comment
Assignees

Comments

@Azher2Ali
Copy link
Contributor

Azher2Ali commented Aug 19, 2024

Summary of request

This request involves the removal of the docker/object-storage-init/data/oicr.icgc.test directory from the codebase. The directory contains object storage configurations related to the ICGC project, which are no longer relevant or in use. Removing these obsolete configurations is part of the effort to clean up the codebase and eliminate outdated ICGC references.

Desired solution

The desired solution is to delete the docker/object-storage-init/data/oicr.icgc.test directory and any related references in the codebase. This will help streamline the project by removing unnecessary files and reducing potential confusion regarding unused configurations.

Additional context

Include any relevant context or screenshots regarding your request here.
https://github.com/overture-stack/SONG/tree/develop/docker/object-storage-init/data/oicr.icgc.test

https://github.com/overture-stack/SONG/blob/develop/Makefile#L93

https://github.com/overture-stack/SONG/blob/develop/Makefile#L97

https://github.com/overture-stack/SONG/blob/develop/Makefile#L99

https://github.com/overture-stack/SONG/blob/develop/Makefile#L102

https://github.com/overture-stack/SONG/blob/develop/Makefile#L103

https://github.com/overture-stack/SONG/blob/develop/Makefile#L104

@joneubank
Copy link
Contributor

This data is used in the docker-compose setup which is in place for dev purposes. It is mounted here: https://github.com/overture-stack/SONG/blob/develop/docker-compose.yml#L132

We need to instead update the default bucket names in the docker-compose so they don't reference icgc and then update the directory names for the data that you pointed to so that it uses the new data bucket name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants