-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: toggle between "show changed files only" and "show all files" while reviewing PRs #1067
Comments
Hi, thanks for the suggestion! Do you think a toggle button will do or will something more be needed? I looked at the use cases you mentioned and have the feeling this feature, if built, has to do more than just introducing a switch between all-files vs changed-files. For example, in the all-files mode, clicking a file will navigate to the code page, but that might not be what you want. But I could be wrong. Any clarification and further thought is appreciated. |
Hi Danh! Sorry for the late, well... The dreamOpening a from the all-files mode should add a panel, similar to the ones showed by Github for every changed file in the "right" position:
This opens up to a lot of possible scenarios:
Obviously, I'm thinking freely without caring about what's feasible and what not 😉 The "good enough"The toggle and the "open file" (opening the file in the GitHub's UI, not the raw file) button would be useful enough 😊 What do you think? 😊 |
Thanks @NoriSte. This is a very interesting idea. Everything in the "dream" part makes sense to me. Couple of questions:
|
Yep with the option to "stick" it, it shouldn't disappear if I move the mouse out because the most important purpose is "comparing" it (not through a diff but through eyes) with the files changed in the PR
You're right, sorry: |
Thanks! We'll be working on this. If you think of anything else that could be improved about this, please do let me know. |
Thank you ❤️ and have a nice weekend!! |
Description
As a Pro user, when I'm reviewing PRs, I'd fancy toggle between the changed files only and the whole tree. This way, I can easily check that:
Anyway: thanks, Octotree is an amazing product 😊
The text was updated successfully, but these errors were encountered: