Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the security of the catalog #172

Open
aminelouati opened this issue Apr 3, 2019 · 0 comments
Open

Improve the security of the catalog #172

aminelouati opened this issue Apr 3, 2019 · 0 comments

Comments

@aminelouati
Copy link
Member

aminelouati commented Apr 3, 2019

Actually, the security of the catalog is handled by this property pa.catalog.security.required.sessionid.

When disabled (value =false), then sessionid is not required. In this case, providing good, wrong or empty value gives the same result.

When enabled (value =true), then normally providing a good sessionid has to be required which is not the case for most of the methods. Indeed, checkAccessBySessionIdForBucketAndThrowIfDeclined method asks first about public buckets. So if is false then sessionId is completely neglected.

public void checkAccessBySessionIdForBucketAndThrowIfDeclined(boolean sessionIdRequired, String sessionId,
            String bucketName) {
        if (!isAPublicBucket(bucketName) && sessionIdRequired) {
            checkBucketPermission(sessionId, bucketName);

        }

    }

However, checkAccessBySessionIdForOwnerOrGroupAndThrowIfDeclined seems to be correct.

The overall behavior should be improved which is quite complex (new design). Indeed, using the script referencing from the studio requires that the script is loaded from a public bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant