Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value labels of discrete bar charts sit too high in Figma #4022

Open
sophiamersmann opened this issue Oct 7, 2024 · 1 comment
Open

Value labels of discrete bar charts sit too high in Figma #4022

sophiamersmann opened this issue Oct 7, 2024 · 1 comment
Labels
bug polish priority 3 - nice to have soonish and small Do it some time soon like next cooldown viz

Comments

@sophiamersmann
Copy link
Member

Description

Bar labels of discrete bar charts are correctly positioned in our static exports, but when imported to Figma, the bar labels sit a little too high (see screenshots)

Screenshots

Example: https://ourworldindata.org/grapher/deaths-in-wars-by-war-1800-2011-bar-chart

Static chart (bar labels look ok)
Image

In Figma (bar labels sit too high)
Image
@sophiamersmann
Copy link
Member Author

Probably switching from dominant-baseline to dy fixes this.

@sophiamersmann sophiamersmann added the soonish and small Do it some time soon like next cooldown label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug polish priority 3 - nice to have soonish and small Do it some time soon like next cooldown viz
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophiamersmann