Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player stream time can show "undefined" #3857

Open
gabek opened this issue Jul 30, 2024 · 10 comments
Open

Player stream time can show "undefined" #3857

gabek opened this issue Jul 30, 2024 · 10 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Web frontend Issues dealing with the web site

Comments

@gabek
Copy link
Member

gabek commented Jul 30, 2024

Share your bug report, feature request, or comment.

I'm not sure exactly in what case this happens, but we should be able to easily reproduce it in Storybook by trying different time combinations.

image

@gabek gabek added bug Something isn't working good first issue Good for newcomers Web frontend Issues dealing with the web site labels Jul 30, 2024
Copy link

Good First Issue

This item was marked as a good first issue because of the following:

  • It's self contained as a single feature or change.
  • Is clear when it's complete.
  • You do not need deep knowledge of Owncast to accomplish it.

Next Steps

  1. Comment on this issue before starting work so it can be assigned to you. Also, this issue may have been filed with limited detail or changes may have occurred that are worth sharing with you before you start work.
  2. Drop by our community chat if you'd like to be involved in more real-time discussion around Owncast to talk about this change.
  3. Follow the project's getting started tips to make sure you can build and run the project from source.

Notes

  • Development takes place on the develop branch.
  • We use Storybook for testing and developing React components. npm run storybook. A hosted version is available for viewing.
  • If you need to install the Go programming language to run the Owncast backend it's simple from here.
  • Active contributors get an Owncast t-shirt! Ask about it if you feel like you've been contributing and haven't yet been given one.

New to Git?

If you're brand new to Git you may want a short primer about the Fork -> Commit -> Pull Request workflow that enables changes to get made collaboratively using git. Visit the First Contributions project to learn step-by-step how to commit a change to a Git repository such as this one.

@cnfairall
Copy link

Hi! I would like to take this on :)

@gabek
Copy link
Member Author

gabek commented Aug 18, 2024

Thanks so much, @cnfairall!

@cnfairall
Copy link

@gabek I'm stuck in setting up dev environment. sent you msg on rocket chat as well. I have go installed but I don't think I managed to install anything else, not sure how
Screenshot (10)

@cnfairall
Copy link

hey, I don't think I'll be able to do this ticket. I tried for over a week to set up my environment but it proved too complicated for my knowledge level. sorry about it!

@zockicookie
Copy link
Contributor

@cnfairall I had some problems with the first setup as well. You will need to set up ffmpeg and gcc. I managed to avoid the cgo error by calling "CGO_ENABLED=1 go run main.go" when powering up the backend.

@zockicookie
Copy link
Contributor

@gabek since this is open again, I would love to try my luck with this one.

@gabek
Copy link
Member Author

gabek commented Sep 5, 2024

Sure, thank you @zockicookie!

@mahmed2000
Copy link
Contributor

Does this happen on builds after #3727 was fixed?

@gabek
Copy link
Member Author

gabek commented Sep 24, 2024

@mahmed2000 I thought it was, but that might be incorrect. I think it's good to get this test in that @zockicookie is working on, and then we can close this since it hasn't been able to be reproduced, and I could be wrong on the version(s) that I saw this on. Thanks for chiming in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Web frontend Issues dealing with the web site
Projects
None yet
Development

No branches or pull requests

4 participants