Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 12.3 #1362

Closed
37 of 44 tasks
felix-schwarz opened this issue May 27, 2024 · 28 comments
Closed
37 of 44 tasks

[RELEASE] 12.3 #1362

felix-schwarz opened this issue May 27, 2024 · 28 comments
Labels
Approved by QA Approved by QA

Comments

@felix-schwarz
Copy link
Contributor

felix-schwarz commented May 27, 2024

Release a new version

Xcode version to work with: 16.0 (16A242d)

TASKS:

Git & Code

  • [GIT] Create branch release/[major].[minor].[patch] (freeze the code)
  • [DEV] Update APP_SHORT_VERSION [major].[minor].[patch] in ownCloud.xcodeproj/project.pbxproj
  • [TRFX] Update translations from transifex branch.
  • [TRFX] Check for missing translations.
  • [DIS] Update changelog
  • [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
  • [DEV] Changelog: Created a folder for the new version like $majorVersion.$minorVersion.$patchVersion_YYYY-MM-DD
  • [DEV] Changelog: Moved all changelog files from the unreleased folder to the new version folder
  • [DEV] Inform Documentation-Team for the upcoming major/minor release with new version tag (notify #documentation-internal)
  • [QA] Design Test plan
  • [QA] Regression Test plan
  • [DOC] Update https://owncloud.com/mobile-apps/#ios version numbers (notify #marketing)
  • [GIT] Merge branch release/[major].[minor].[patch] in master
  • [GIT] Create tag and sign it [major].[minor].[patch]
  • [GIT] Add the new release on GitHub ios-app
  • [DEV] ownBrander: Update the ownBrander git tag in repository customer_portal to new release tag
  • [DEV] Update used Xcode version for the release in .xcode-version
  • [DEV] Inform #documentation about the new release to set new documentation branch tag

If it is required to update the iOS-SDK version:

  • [GIT] Create branch library release/[major].[minor].[patch](freeze the code)
  • [mail] inform #marketing about the new release.
  • [DIS] Update README.md (version number, third party, supported versions of iOS, Xcode)
  • [DIS] Update changelog
  • [GIT] Merge branch release/[major].[minor].[patch] in master
  • [GIT] Create tag and sign it [major].[minor].[patch]
  • [GIT] Add the new release on GitHub ios-sdk

If it is required to update third party:

  • [DIS] Update THIRD_PARTY.txt

App Store

  • [DIS] App Store Connect: Create a new version following the [major].[minor].[patch]
  • [DIS] App Store Connect: Trigger Fastlane screenshots generation and upload
  • [DIS] Upload the binary to the App Store
  • [DIS] App Store Connect: Trigger release (manually)
  • [DIS] App Store Connect: Decide reset of iOS summary rating (Default: keep)
  • [DIS] App Store Connect: Update description if necessary (coordinated with #marketing)
  • [DIS] App Store Connect: Update changelogs
  • [DIS] App Store Connect: Submit for review

BUGS & IMPROVEMENTS:

QA

Regression test: https://github.com/owncloud/QA/blob/master/Mobile/iOS/Executions/Version%2012.3/Regression.md

Reports:

@jesmrec
Copy link
Contributor

jesmrec commented Sep 13, 2024

(1) [WONT FIX]

In iOS18 (latest beta-RC), app icon is not displayed after fresh install. Opening the app the icon is recovered and gone again:

ScreenRecording_09-13-2024.16.MP4

This effect does not happen in iOS 17

Tested with archived ipa, not debug.

iPhoneXR v18.0
iPad v17.6.1

app 22d3551
sdk 8ae91ff

@felix-schwarz
Copy link
Contributor Author

felix-schwarz commented Sep 13, 2024

@jesmrec (1) appears to be a bug in iOS 18 and nothing we can fix from our side. I guess a reboot will fix that. FWIW I didn't see it on my test iPad and test iPhone.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2024

(2) (question)

in iPhoneXR, the following warning appears after a fresh install in iOS18:

Screenshot 2024-09-03 at 14 31 45

Any affection for the app in terms of confidentially or security?

iPhoneXR v18

app 22d3551
sdk 8ae91ff

@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2024

(3) [FIXED IN LATEST COMMITS]

  1. Select any file and Duplicate
  2. File is created with no thumbnail
  3. After some seconds -> error creating file
  4. Error solved by cancelling
  5. By swiping down, the file is correctly created

Expected:: file correctly duplicated in first instance

ScreenRecording_09-16-2024.09-45-27_1.MP4

iPhone XR iOS18
iPad iPadOS17

app 22d3551
sdk 8ae91ff

@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2024

(4)

  1. Select many files to upload (for this example, i used 100)

Current: media-import imports everything, but files stay in the list with the spinner and greyed out. A part of them upload to the server, but most of them are stucked in Status and greyed out in list of files. Killing the app and reopening does not fix the problem.

Expected: Everything uploaded

I caught some logs:

ownCloud_17_Sep_2024_at_09_02_48.log.txt

In my iPadOS 17, it works like a charm. (some iOS version dependency?)

EDIT: After some time, some re-openings in the app, i realised that everything was uploaded. But, it was not a short time and many re-openings.

iPhone XR iOS18

app 0e7648c
sdk 8ae91ff

@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2024

(5) [FIXED IN LATEST COMMITS]

Downloads.

I have a folder Test with 5 images: land1.jpg, land2.jpg, land3.jpg, land4.jpg, land5.jpg

I click one by one, in order to download and preview them

2 out of 5 don't download and get stucked in Status with a spinner in the file list. Killing and reopening the app does not fix the problem:

ScreenRecording_09-16-2024.14.MP4

I caught some logs, not corresponding the recording above (let me know if you need something different):

ownCloud_16_Sep_2024_at_12_42_28.log.txt

This is just an explicative example. The point is, that downloading files randomly, not always are finished for any reason.

I was only able to reproduce in iOS18, not in iOS17.

app 22d3551
sdk 8ae91ff

@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2024

(6) [FIXED IN LATEST COMMITS]

Previewing MS Office files (docx, xlsx...)

In iPadOS17 and stable version: content is displayed and previewed

iOS18:

Screenshot 2024-09-16 at 13 20 09

EDIT: same for txt files

app 22d3551
sdk 8ae91ff

@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2024

(7) [FIXED]

I get a Content Unavailable error sometimes when trying to browse through Files App in a oCIS account over iOS18. Not reproducible with oC10 accounts in iOS18, and working fine in iOS17.

I tried the same test with demo.owncloud.com and worked fine. I can provide the server in which i reproduce the error, that is a

ownCloud Web UI 8.0.5
Infinite Scale 5.0.7 Community

It seems that is easier to reproduce when browsing back rom list of files to list of resources (Personal, spaces, share with me)

ScreenRecording_09-17-2024.10-10-13_1.MP4

app0e7648c
sdk 8ae91ff

@felix-schwarz
Copy link
Contributor Author

Re (2): this message is expected when trying to connect to local servers. If a user presses "Don't allow", they will not be able to access their local server(s).

felix-schwarz added a commit to owncloud/ios-sdk that referenced this issue Sep 17, 2024
…nted HTTP request removals/reschedules by other processes; fixing finding (4) in owncloud/ios-app#1362
@felix-schwarz
Copy link
Contributor Author

Re (7): As far as I can see, this is just "running out of memory". I saw it only when I had ongoing TUS uploads carried over from the app, where the allocation of even a small buffer to segment the uploaded file might make the whole File Provider trip over the limit.

I'll perform some further debugging and checks in the Simulator, however.

But since the FP is no longer used by any other parts of the app other than the FP itself, you can continue with QA on all other parts of the app.

felix-schwarz added a commit to owncloud/ios-sdk that referenced this issue Sep 18, 2024
…nted HTTP request removals/reschedules by other processes; fixing finding (4) in owncloud/ios-app#1362
@jesmrec
Copy link
Contributor

jesmrec commented Sep 18, 2024

(8)

Operations in Files App are returning crashes. For example, removing 10 files:

ScreenRecording_09-18-2024.11-13-01_1.MP4

Files are not removed from server.

Logs: ownCloud_18_Sep_2024_at_11_11_23.log.txt

Other basic operations like remove, duplicate or copy/paste behave the same

app: 68826f6c
sdk: 8da653e

@hosy
Copy link
Collaborator

hosy commented Sep 18, 2024

(8)

Operations in Files App are returning crashes. For example, removing 10 files:

ScreenRecording_09-18-2024.11-13-01_1.MP4
Files are not removed from server.

Logs: ownCloud_18_Sep_2024_at_11_11_23.log.txt

Other basic operations like remove, duplicate or copy/paste behave the same

app: 68826f6c sdk: 8da653e

Can you find a crash log or check the console while performing this task Xcode > Window > Devices > Select Device > Open Console

@jesmrec
Copy link
Contributor

jesmrec commented Sep 18, 2024

@hosy i saw nothing relevant, i also checked the Window > Organizer > Crashes, nothing from the latest day:

Screenshot 2024-09-18 at 12 15 54

I'm testing with a released signed ipa (not debug), it may have something to do. I'll try to get something from a debug build.

@hosy
Copy link
Collaborator

hosy commented Sep 18, 2024

@jesmrec on the Organizer window you can only find crash reports from TestFlight or App Store.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 18, 2024

@jesmrec on the Organizer window you can only find crash reports from TestFlight or App Store.

i checked, just in case. I've just checked with a debug build and i see nothing in Xcode > Window > Devices > Select Device > Open Console affecting the described error. Only a couple of reports but from simulator, not from real device i reproduced the problem with.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 18, 2024

(9) [FIXED]

A weird scenario, that i reproduce in both iOS17 and iOS18

  1. Add account to the device (i tested with two, also valid)
  2. Open the Photos app
  3. Select some pictures or videos and share with oC

-> Folder picker is opened but accounts appear as Connecting forever. Both accounts are green in the app

  1. In spite of the Connecting status, select any target folder for the file

-> Uploading dialog is forever in the screen. Checking the app, the file is greyed out and need to kill the app and reopen to finish the upload

ScreenRecording_09-18-2024.13-25-29_1.MP4

If you need logs, please ping me. I tried to get logs from the app, but the log file form that scenario weights > 600MB.

EDIT: as @felix-schwarz requested, log file only with latest 8000 lines was caught:

logShare.txt

app: 68826f6c
sdk: 8da653e

@felix-schwarz
Copy link
Contributor Author

felix-schwarz commented Sep 18, 2024

Re (9): thanks for the video & logs. The Share Extension Info.plist was missing the necessary keys to allow insecure http connections, sending the OCCore into an infinite loop of connection attempts. I added the keys with the latest commit ( ea52e9e ) in #1385, so that issue should now be fixed.

@felix-schwarz
Copy link
Contributor Author

Re (7) and (8): I've been able to identify a few more opportunities to reduce the peak memory footprint of the File Provider further and put all of the changes it in #1387.

@jesmrec Please check if that branch fixes the issues you see.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 19, 2024

Issue (7) is fixed. But (8) is reproducible in populated accounts.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 19, 2024

(10) [FIXED]

These are the available menus for the same item in Files App for iPadOS17 and iOS18

iOS18 iPadOS17
Screenshot 2024-09-19 at 13 47 28 Screenshot 2024-09-19 at 13 48 06

Share by cloud is missing.

app e0478794
sdk 87c68c0

iPhone XR v18.0
iPad 10th gen v17.6

@hosy
Copy link
Collaborator

hosy commented Sep 19, 2024

@jesmrec regarding (10):

Just had a look and it es available for me. Tested on demo.owncloud.com:

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2024-09-19 at 14 41 55

@jesmrec
Copy link
Contributor

jesmrec commented Sep 19, 2024

i rechecked with same devices and versions and now it is available... pretty weird. I will take another look, just in case i find any reason. Thanks for checking @hosy

@jesmrec
Copy link
Contributor

jesmrec commented Sep 19, 2024

About the share by cloud: if server is not secured (https with self signed or similar), the sharing is not opened. Something similar happened in the previous reports that @felix-schwarz fixed. Looks like that:

ScreenRecording_09-19-2024.15-03-56_1.MP4

Something fixable? should go to 12.3.1? what do you think?

@felix-schwarz
Copy link
Contributor Author

Re (10): @jesmrec Like for the share extension, I added a NSAppTransportSecurity section to the Info.plist in e196e02 (release/12.3.0) to allow plain HTTP connections. Please check if that fixes it.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 20, 2024

@felix-schwarz with the following:

app e196e02
sdk b955bce

unfortunately i still reproduce this. If some extra info is required, let me know.

@hosy
Copy link
Collaborator

hosy commented Sep 20, 2024

@jesmrec I´ve added the NSAppTransportSecurity to two missing targets. Please have a look again with the commit 5ed2b9f38196e012c38126a3c56b6341220540ca. File Provider UI target was missing for your finding.

@jesmrec
Copy link
Contributor

jesmrec commented Sep 20, 2024

@hosy, fixed with your commit!

@jesmrec
Copy link
Contributor

jesmrec commented Sep 20, 2024

Release 12.3.0 is approved on my side.

Xcode version: 16.0 (16A242d)

Approved commits:

  • app: 5ed2b9f
  • sdk: b955bce

Devices:

  • iPhone XR - iOS 18.0
  • iPad 10th gen - iPadOS 17.6.1

QA:

Reports in QA-phase in the top message

Known issues and regards:

  • In the iPhone XR with iOS 18, the app icon is not always displayed in the device list of apps, as reported here. As stated by dev team, this is probably an iOS bug.

  • Shortcuts feature (IAP) is not available

  • Files provider (Files App): there are known memory issues that caused problems with crashes like this one. Some work was done to mitigate them, but the issues are not completely gone and need deeper research to be fixed. They are likely reproducible in populated accounts.

  • Bulk uploads worked fine till ~400 files. A higher number uses to lead to errors, probably because the known memory issues.

@jesmrec jesmrec added the Approved by QA Approved by QA label Sep 20, 2024
@hosy hosy closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

No branches or pull requests

3 participants