Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Action availability for file in shared folder: Unshare instead of Delete #1379

Closed
felix-schwarz opened this issue Aug 29, 2024 · 4 comments
Assignees

Comments

@felix-schwarz
Copy link
Contributor

felix-schwarz commented Aug 29, 2024

Steps to reproduce

  1. Navigate to a shared folder
  2. Upload a file into the shared folder
  3. Tap ... next to the item

Expected behavior

The action Delete is shown.

Actual behavior

The action Delete is not shown. Instead, Unshare is shown, which is not really applicable here.

Client configuration

Version 12.3, but other releases should be similarly affected.

Server configuration

ocis, demo.owncloud.com

Cause

A bug in ocis (owncloud/ocis#9933, owncloud/ocis#8455) breaks the client's internal chain of item IDs, so items inside shared folders erroneously are seen as "root" shared items themselves, leading to side effects like the wrong actions being shown to the user. F.ex. Unshare (which of course fails) is shown, but Delete (which would work and be useful) is not.

Resolution

This problem should no longer occur as soon as owncloud/ocis#9933 is fixed.

This issue was filed to document the issue and its cause.

@felix-schwarz
Copy link
Contributor Author

Fixed by owncloud/ocis#10172 (verified on https://ocis.ocis.master.owncloud.works/ with Infinite Scale 6.5.0+fdc61d043 Community).

@felix-schwarz felix-schwarz self-assigned this Oct 7, 2024
@jesmrec
Copy link
Contributor

jesmrec commented Oct 10, 2024

@felix-schwarz if Delete option is expected in items inside a shared folder, i am missing it. I caught the following video from demo.owncloud.com and same result in https://ocis.ocis.master.owncloud.works/:

ScreenRecording_10-10-2024.10-57-28_1.MP4

is something missing?

iPhone XR iOS18.0
v12.3.1

@felix-schwarz
Copy link
Contributor Author

@jesmrec This looks like the folder was shared read-only. Did you share that folder to Katherine with full permissions?

@jesmrec
Copy link
Contributor

jesmrec commented Oct 11, 2024

yeah, that was the permissions... i set the default ones expecting to be granted those ones.

That's OK for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants