Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a file inside a received shared folder is moved to the trashbin of the sharer not the receiver #1124

Open
individual-it opened this issue Dec 17, 2020 · 10 comments
Labels
Category:Defect Existing functionality is not working as expected Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Type:Bug

Comments

@individual-it
Copy link
Member

  1. as einstein share a folder with marie
  2. as marie accept the share
  3. as marie delete Shares/received-share/some-file
  4. as marie check the trash-bin => the file is not listed
  5. as einstein check the trash-bin => the deleted file is listed but with a wrong path (.../)
    image
  6. as einstein try to restore the deleted file => it fails with HTTP 404

expected:
in oC10 deleting a file inside a received share will move it to the trashbin of the receiver

@SwikritiT
Copy link
Contributor

I couldn't recreate the exact same error. Maybe it has been fixed. Deleting a file inside a received shared folder is moved to the trash-bin of the receiver . However , when I try to restore the file it gives me error. I have written some tests for it.

@individual-it
Copy link
Member Author

issues was not fixed by the PR, only tests have been added

@settings settings bot removed the bug label Jan 12, 2021
@refs refs changed the title deleting a file inside a received shared folder is moved to the trash-bin of the sharer not the receiver Deleting a file inside a received shared folder is moved to the trash-bin of the sharer not the receiver Jan 13, 2021
@refs refs added Category:Defect Existing functionality is not working as expected Type:Bug Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced labels Jan 13, 2021
@phil-davis
Copy link
Contributor

@jasson99 please mention how you are able to reproduce this issue, including if it happens only on one storage...

@phil-davis phil-davis reopened this Jun 14, 2021
@jasson99
Copy link
Contributor

Yes, this issue is still present in ocis-storage. This can be reproduced in the webui as well as through api. Even the related api tests which were tagged with this issue are still failing with this specific reason.
Screenshot from 2021-06-14 17-37-56

@jasson99
Copy link
Contributor

I think this is same as : #1128

@phil-davis
Copy link
Contributor

@jasson99 yes. This issue 1124 is mentioned in expected failures, but #1128 is not. So if we close this issue, then we need to update expected-failures also.

@hodyroff hodyroff changed the title Deleting a file inside a received shared folder is moved to the trash-bin of the sharer not the receiver Deleting a file inside a received shared folder is moved to the trashbin of the sharer not the receiver Aug 11, 2021
@pmaier1
Copy link
Contributor

pmaier1 commented Aug 11, 2021

expected:
in oC10 deleting a file inside a received share will move it to the trashbin of the receiver

In oC 10 the deleted file would be in both, the trash bin of the user who deleted the file and the trash bin of the user who owns the file (sharer).

@PrajwolAmatya
Copy link
Contributor

With latest master, when share receiver deletes file from shared folder, the deleted file is listed in the sharer's trashbin and not listed in share receiver's trashbin. Also, sharer is able to restore the deleted file, which is available for both sharer and the receiver. As part of issue owncloud/web#10259, I have added an e2e test according to the current behavior. owncloud/web#10550

@micbar
Copy link
Contributor

micbar commented Jun 5, 2024

@butonic @kobergj @aduffeck That looks like a bug to me.

@ScharfViktor
Copy link
Contributor

That looks like a bug to me.

@micbar what do you expect here? receiver should listed deleted files? it's not implemented in ocis

in case sharing folder and deleting folder content:
PROPFIND https://localhost:9200/remote.php/dav/spaces/trash-bin/{mountpoint/sharedFolder} -> 500 method not implemented

in case sharing file and deleting file:
PROPFIND https://localhost:9200/remote.php/dav/spaces/trash-bin/{virtual/shares} -> 500 method not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Type:Bug
Projects
Status: Qualification
Development

No branches or pull requests

10 participants