diff --git a/.drone.star b/.drone.star index 1ea76b9d7f9..a5eec535658 100644 --- a/.drone.star +++ b/.drone.star @@ -123,8 +123,6 @@ config = { ], "oCISSharingInternal2": [ "webUISharingInternalUsers", - "webUISharingInternalUsersBlacklisted", - "webUISharingInternalUsersCollaborator", ], "oCISSharingInternal3": [ "webUISharingInternalGroupsSharingIndicator", @@ -230,8 +228,6 @@ basicTestSuites = [ "webUISharingInternalGroupsEdgeCases", "webUISharingInternalGroupsSharingIndicator", "webUISharingInternalUsers", - "webUISharingInternalUsersBlacklisted", - "webUISharingInternalUsersCollaborator", "webUISharingInternalUsersShareWithPage", "webUISharingInternalUsersSharingIndicator", "webUISharingPermissionsUsers", diff --git a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md index 56009112d7e..ce49c0d244a 100644 --- a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md +++ b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md @@ -13,36 +13,17 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUILogin/openidLogin.feature:50](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/openidLogin.feature#L50) - [webUILogin/openidLogin.feature:60](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/openidLogin.feature#L60) -### [when sharer renames the shared resource, sharee get the updated name](https://github.com/owncloud/ocis/issues/2256) -- [webUIRenameFiles/renameFiles.feature:227](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L227) - -### [Cannot create users with special characters](https://github.com/owncloud/ocis/issues/1417) -- [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:37](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L37) -- [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:38](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L38) -- [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:35](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L35) -- [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:36](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L36) - - ### [Share additional info](https://github.com/owncloud/ocis/issues/1253) - [webUISharingInternalUsersShareWithPage/shareWithUsers.feature:126](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersShareWithPage/shareWithUsers.feature#L126) ### [Different path for shares inside folder](https://github.com/owncloud/ocis/issues/1231) -### [Listing shares via ocs API does not show path for parent folders](https://github.com/owncloud/ocis/issues/1231) -- [webUISharingPublicManagement/shareByPublicLink.feature:110](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L111) - ### [Conflict / overwrite issues with TUS](https://github.com/owncloud/ocis/issues/1294) - [webUIUpload/uploadFileGreaterThanQuotaSize.feature:11](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/uploadFileGreaterThanQuotaSize.feature#L11) ### [restoring a file deleted from a received shared folder is not possible](https://github.com/owncloud/ocis/issues/1124) - [webUITrashbinRestore/trashbinRestore.feature:176](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L176) -### [Comments in sidebar](https://github.com/owncloud/web/issues/1158) -- [webUIFilesDetails/fileDetails.feature:84](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L84) -- [webUIFilesDetails/fileDetails.feature:98](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L98) -- [webUIFilesDetails/fileDetails.feature:113](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L113) -- [webUIFilesDetails/fileDetails.feature:128](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L128) - ### [Deletion of a recursive folder from trashbin is not possible](https://github.com/owncloud/product/issues/188) - [webUITrashbinDelete/trashbinDelete.feature:51](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L51) - [webUITrashbinDelete/trashbinDelete.feature:65](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L65) @@ -70,10 +51,5 @@ Other free text and markdown formatting can be used elsewhere in the document if ### [empty subfolder inside a folder to be uploaded is not created on the server](https://github.com/owncloud/web/issues/6348) - [webUIUpload/upload.feature:43](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L43) -### [Favorites deactivated in ocis temporarily](https://github.com/owncloud/ocis/issues/1228) -- [webUIFilesDetails/fileDetails.feature:47](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L47) -- [webUIFilesDetails/fileDetails.feature:67](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L67) -- [webUIRenameFiles/renameFiles.feature:250](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L250) - ### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859) - [webUISharingAcceptShares/acceptShares.feature:105](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L105) diff --git a/tests/acceptance/features/webUIFilesDetails/fileDetails.feature b/tests/acceptance/features/webUIFilesDetails/fileDetails.feature index e16abaa871b..8ab02a25a95 100644 --- a/tests/acceptance/features/webUIFilesDetails/fileDetails.feature +++ b/tests/acceptance/features/webUIFilesDetails/fileDetails.feature @@ -43,103 +43,6 @@ Feature: User can open the details panel for any file or folder Then the "people" details panel should be visible And the "small" preview of thumbnail should be visible in the "people" panel - @files_versions-app-required @ocis-reva-issue-39 - Scenario: View different areas of the app-sidebar for a file in favorites page - Given user "Alice" has created file "lorem.txt" in the server - And the user has browsed to the personal page - And user "Alice" has favorited element "lorem.txt" in the server - And the user has browsed to the favorites page - When the user opens the sidebar for file "lorem.txt" on the webUI - Then the app-sidebar should be visible - And the "details" details panel should be visible - And the "big" preview of thumbnail should be visible in the "details" panel - When the user switches to "actions" panel in details panel using the webUI - Then the "actions" details panel should be visible - And the "small" preview of thumbnail should be visible in the "actions" panel - When the user switches to "people" panel in details panel using the webUI - Then the "people" details panel should be visible - And the "small" preview of thumbnail should be visible in the "people" panel - When the user switches to "versions" panel in details panel using the webUI - Then the "versions" details panel should be visible - And the "small" preview of thumbnail should be visible in the "versions" panel - - @files_versions-app-required @ocis-reva-issue-39 - Scenario: View different areas of the app-sidebar for a folder in favorites page - Given user "Alice" has created folder "simple-folder" in the server - And the user has browsed to the personal page - And user "Alice" has favorited element "simple-folder" in the server - And the user has browsed to the favorites page - When the user opens the sidebar for folder "simple-folder" on the webUI - Then the app-sidebar should be visible - And the "details" details panel should be visible - And the "big" preview of thumbnail should be visible in the "details" panel - When the user switches to "actions" panel in details panel using the webUI - Then the "actions" details panel should be visible - And the "small" preview of thumbnail should be visible in the "actions" panel - When the user switches to "people" panel in details panel using the webUI - Then the "people" details panel should be visible - And the "small" preview of thumbnail should be visible in the "people" panel - - @issue-1158 @comments-app-required @public_link_share-feature-required - Scenario: user shares a file through public link and then the details dialog should work in a Shared by link page - Given user "Alice" has created folder "simple-folder" in the server - And the user has browsed to the personal page - And user "Alice" has created a public link with following settings in the server - | path | simple-folder | - And the user has browsed to the shared-via-link page - When the user opens the actions sidebar panel of folder "simple-folder" on the webUI - Then the "small" preview of thumbnail should be visible in the "actions" panel - When the user switches to "people" panel in details panel using the webUI - Then the "people" details panel should be visible - When the user switches to "comments" panel in details panel using the webUI - Then the "comments" details panel should be visible - - @issue-1158 @comments-app-required - Scenario: user shares a file and then the details dialog should work in a Shared with others page - Given user "Alice" has created folder "simple-folder" in the server - And the user has browsed to the personal page - And user "Alice" has shared folder "simple-folder" with user "Brian" in the server - When the user browses to the shared-with-others page - Then folder "simple-folder" should be listed on the webUI - When the user opens the sidebar for folder "simple-folder" on the webUI - Then the app-sidebar should be visible - And the "big" preview of thumbnail should be visible in the "details" panel - When the user switches to "people" panel in details panel using the webUI - Then the "people" details panel should be visible - When the user switches to "comments" panel in details panel using the webUI - Then the "comments" details panel should be visible - - @issue-1158 @comments-app-required - Scenario: user shares a folder via link and then the details dialog should work in a Shared with others page - Given user "Alice" has created folder "simple-folder" in the server - And the user has browsed to the personal page - And user "Alice" has created a new public link for resource "simple-folder" in the server - When the user browses to the shared-with-others page - Then folder "simple-folder" should be listed on the webUI - When the user opens the sidebar for folder "simple-folder" on the webUI - Then the app-sidebar should be visible - And the "big" preview of thumbnail should be visible in the "details" panel - When the user switches to "people" panel in details panel using the webUI - Then the "people" details panel should be visible - When the user switches to "comments" panel in details panel using the webUI - Then the "comments" details panel should be visible - - @issue-1158 @comments-app-required - Scenario: the recipient user should be able to view different areas of details panel in Shared with me page - Given user "Alice" has created folder "simple-folder" in the server - And the user has browsed to the personal page - And user "Alice" has shared folder "simple-folder" with user "Brian" in the server - And the user re-logs in as "Brian" using the webUI - When the user browses to the shared-with-me page - Then folder "simple-folder" should be listed on the webUI - When the user opens the sidebar for folder "simple-folder" on the webUI - Then the app-sidebar should be visible - And the "big" preview of thumbnail should be visible in the "details" panel - When the user switches to "people" panel in details panel using the webUI - Then the "people" details panel should be visible - When the user switches to "comments" panel in details panel using the webUI - Then the "comments" details panel should be visible - @ocis-reva-issue-106 Scenario: without any share the shared-with-others page should be empty When the user browses to the shared-with-others page using the webUI diff --git a/tests/acceptance/features/webUIRenameFiles/renameFiles.feature b/tests/acceptance/features/webUIRenameFiles/renameFiles.feature index 08eb8ca3c8e..956d2fb8c9e 100644 --- a/tests/acceptance/features/webUIRenameFiles/renameFiles.feature +++ b/tests/acceptance/features/webUIRenameFiles/renameFiles.feature @@ -108,21 +108,6 @@ Feature: rename files Then file "loremz.dat" should be listed on the webUI And file "loremy.tad" should be listed on the webUI - # these are invalid file names on oc10 - @notToImplementOnOCIS - Scenario Outline: Try to rename a file using forbidden characters - Given user "Alice" has logged in using the webUI - When the user tries to rename file "data.zip" to "" using the webUI - Then the "error" message with header 'Failed to rename "data.zip" to ""' should be displayed on the webUI - And the user clears all error message from the webUI - And file "data.zip" should be listed on the webUI - And file "" should not be listed on the webUI - Examples: - | filename | - | lorem\txt | - | \\.txt | - | .htaccess | - Scenario Outline: Rename a file/folder using forward slash in its name Given user "Alice" has logged in using the webUI @@ -170,95 +155,13 @@ Feature: rename files Then the error message 'The name cannot be equal to "."' should be displayed on the webUI dialog prompt And file 'data.zip' should be listed on the webUI - @notToImplementOnOCIS - # This is valid file name for ocis - Scenario: Rename a file to .part (on oc10) - Given user "Alice" has logged in using the webUI - When the user tries to rename file "data.zip" to "data.part" using the webUI - Then the "error" message with header 'Failed to rename "data.zip" to "data.part"' should be displayed on the webUI - @skipOnOC10 Scenario: Rename a file to .part Given user "Alice" has logged in using the webUI When the user renames file "data.zip" to "data.part" using the webUI Then file 'data.part' should be listed on the webUI - Scenario: rename a file on a public share (on ocis) - Given user "Alice" has created folder "simple-folder" in the server - And user "Alice" has uploaded file "lorem.txt" to "simple-folder/lorem.txt" in the server - And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server - When the public uses the webUI to access the last public link created by user "Alice" in a new session - And the user renames file "lorem.txt" to "a-renamed-file.txt" using the webUI - Then file "a-renamed-file.txt" should be listed on the webUI - But file "lorem.txt" should not be listed on the webUI - When the user reloads the current page of the webUI - Then file "a-renamed-file.txt" should be listed on the webUI - But file "lorem.txt" should not be listed on the webUI - And as "Alice" file "simple-folder/a-renamed-file.txt" should exist in the server - And as "Alice" file "simple-folder/lorem.txt" should not exist in the server - - @issue-2249 @notToImplementOnOCIS - Scenario: Rename a file and folder in shared with me page - Given user "Brian" has been created with default attributes and without skeleton files in the server - And user "Brian" has created folder "simple-folder" in the server - And user "Brian" has uploaded file "lorem.txt" to "simple-folder/lorem.txt" in the server - And user "Brian" has uploaded file "lorem.txt" to "lorem.txt" in the server - And user "Brian" has shared file "lorem.txt" with user "Alice" in the server - And user "Brian" has shared folder "simple-folder" with user "Alice" in the server - And user "Alice" has logged in using the webUI - When the user browses to the shared-with-me page - And the user renames file "lorem (2).txt" to "renamed-file.txt" using the webUI - And the user renames folder "simple-folder" to "renamed-folder" using the webUI - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - When the user reloads the current page of the webUI - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - When the user browses to the files page - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - And as "Alice" file "renamed-file.txt" should exist in the server - And as "Alice" folder "renamed-folder" should exist in the server - And as "Brian" file "lorem.txt" should exist in the server - And as "Brian" folder "simple-folder" should exist in the server - - @issue-ocis-2256 - Scenario: Rename a file and folder in shared with others page - Given user "Brian" has been created with default attributes and without skeleton files in the server - And user "Alice" has created folder "simple-folder" in the server - And user "Alice" has shared file "lorem.txt" with user "Brian" in the server - And user "Alice" has shared folder "simple-folder" with user "Brian" in the server - And user "Alice" has logged in using the webUI - When the user browses to the shared-with-others page - And the user renames file "lorem.txt" to "renamed-file.txt" using the webUI - And the user renames folder "simple-folder" to "renamed-folder" using the webUI - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - When the user reloads the current page of the webUI - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - When the user browses to the files page - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - And as "Alice" file "renamed-file.txt" should exist in the server - And as "Alice" folder "renamed-folder" should exist in the server - And as "Brian" file "lorem.txt" should exist in the server - And as "Brian" folder "simple-folder" should exist in the server - - @issue-ocis-1330 - Scenario: Rename a file and folder in favorites page - Given user "Alice" has created folder "simple-folder" in the server - And user "Alice" has favorited element "lorem.txt" in the server - And user "Alice" has favorited element "simple-folder" in the server - And user "Alice" has logged in using the webUI - When the user browses to the favorites page - And the user renames file "lorem.txt" to "renamed-file.txt" using the webUI - And the user renames folder "simple-folder" to "renamed-folder" using the webUI - Then file "renamed-file.txt" should be listed on the webUI - And folder "renamed-folder" should be listed on the webUI - - Scenario: User tries to rename a file that used to exist but does not anymore Given user "Alice" has logged in using the webUI And the following files have been deleted by user "Alice" in the server diff --git a/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature b/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature index 95209c37b82..196b7a621df 100644 --- a/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature +++ b/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature @@ -19,24 +19,6 @@ Feature: Autocompletion of share-with names | finance2 | And the setting "outgoing_server2server_share_enabled" of app "files_sharing" has been set to "no" in the server - @issue-ocis-1417 - Scenario Outline: autocompletion of user having special characters in their usernames - Given these users have been created without initialization and without skeleton files in the server: - | username | password | displayname | email | - | | %regular% | SpecialUser | usrmail@oc.com.np | - And user "regularuser" has created file "data.zip" in the server - And user "regularuser" has logged in using the webUI - And the user has browsed to the personal page - And the user has opened the share dialog for file "data.zip" - When the user types "" in the share-with-field - Then only users and groups that contain the string "" in their name or displayname should be listed in the autocomplete list on the webUI - Examples: - | username | search | - | @-_. | @- | - | -_.ocusr | -_ | - | ocusr-_. | oc | - | _ocusr@ | _u | - @issue-ocis-1317 @issue-ocis-1675 Scenario Outline: autocompletion of user having special characters in their displaynames Given these users have been created without initialization and without skeleton files in the server: diff --git a/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature b/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature deleted file mode 100644 index d0587b9bd9b..00000000000 --- a/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature +++ /dev/null @@ -1,88 +0,0 @@ -@issue-ocis-1328 @issue-6896 @skipOnOCIS -Feature: Sharing files and folders with internal users - As a user - I want to share files and folders with other users - So that those users can access the files and folders - - Background: - Given the administrator has set the default folder for received shares to "Shares" in the server - And these users have been created with default attributes and without skeleton files in the server: - | username | - | Alice | - | Brian | - - - Scenario: member of a blacklisted from sharing group tries to re-share a file or folder received as a share - Given user "Carol" has been created with default attributes and without skeleton files in the server - And user "Carol" has uploaded file "testavatar.jpg" to "testimage.jpg" in the server - And user "Carol" has created folder "simple-folder" in the server - And group "grp1" has been created in the server - And user "Alice" has been added to group "grp1" in the server - And user "Carol" has shared file "testimage.jpg" with user "Alice" in the server - And user "Carol" has shared folder "simple-folder" with user "Alice" in the server - And the administrator has enabled exclude groups from sharing in the server - And the administrator has excluded group "grp1" from sharing in the server - When user "Alice" logs in using the webUI - And the user opens folder "Shares" using the webUI - Then the user should not be able to share file "testimage.jpg" using the webUI - And the user should not be able to share folder "simple-folder" using the webUI - - - Scenario: member of a blacklisted from sharing group tries to re-share a file inside a folder received as a share - Given user "Carol" has been created with default attributes and without skeleton files in the server - And user "Carol" has uploaded file "testavatar.jpg" to "testimage.jpg" in the server - And user "Carol" has created folder "simple-folder" in the server - And group "grp1" has been created in the server - And user "Alice" has been added to group "grp1" in the server - And user "Carol" has created folder "common" in the server - And user "Carol" has moved file "testimage.jpg" to "common/testimage.jpg" in the server - And user "Carol" has shared folder "common" with user "Alice" in the server - And the administrator has enabled exclude groups from sharing in the server - And the administrator has excluded group "grp1" from sharing in the server - And user "Alice" has logged in using the webUI - And the user has opened folder "Shares" - When the user opens folder "common" using the webUI - Then the user should not be able to share file "testimage.jpg" using the webUI - - - Scenario: member of a blacklisted from sharing group tries to re-share a folder inside a folder received as a share - Given these users have been created with default attributes and without skeleton files in the server: - | username | - | Carol | - And group "grp1" has been created in the server - And user "Alice" has been added to group "grp1" in the server - And user "Carol" has created folder "common" in the server - And user "Carol" has created folder "common/inside-common" in the server - And user "Carol" has shared folder "common" with user "Alice" in the server - And the administrator has enabled exclude groups from sharing in the server - And the administrator has excluded group "grp1" from sharing in the server - And user "Alice" has logged in using the webUI - And the user has opened folder "Shares" - When the user opens folder "common" using the webUI - Then the user should not be able to share folder "inside-common" using the webUI - - - Scenario: user tries to share a file or folder from a group which is blacklisted from sharing from files page - Given group "grp1" has been created in the server - And user "Alice" has been added to group "grp1" in the server - And user "Alice" has uploaded file "testavatar.jpg" to "testimage.jpg" in the server - And user "Alice" has created folder "simple-folder" in the server - And the administrator has enabled exclude groups from sharing in the server - And the administrator has excluded group "grp1" from sharing in the server - When user "Alice" logs in using the webUI - Then the user should not be able to share file "testimage.jpg" using the webUI - And the user should not be able to share folder "simple-folder" using the webUI - - - Scenario: user tries to re-share a file from a group which is blacklisted from sharing using webUI from shared with you page - Given group "grp1" has been created in the server - And user "Alice" has been added to group "grp1" in the server - And user "Carol" has been created with default attributes and without skeleton files in the server - And user "Brian" has uploaded file "testavatar.jpg" to "testimage.jpg" in the server - And user "Brian" has shared file "/testimage.jpg" with user "Alice" in the server - And the administrator has enabled exclude groups from sharing in the server - And the administrator has excluded group "grp1" from sharing in the server - And user "Alice" has logged in using the webUI - When the user browses to the shared-with-me page - And the user opens the share dialog for file "testimage.jpg" using the webUI - Then the user should not be able to share file "testimage.jpg" using the webUI diff --git a/tests/acceptance/features/webUISharingInternalUsersCollaborator/shareWithUsers.feature b/tests/acceptance/features/webUISharingInternalUsersCollaborator/shareWithUsers.feature deleted file mode 100644 index 2475bc4708a..00000000000 --- a/tests/acceptance/features/webUISharingInternalUsersCollaborator/shareWithUsers.feature +++ /dev/null @@ -1,35 +0,0 @@ -Feature: Shares collaborator list - As a user - I want to check the collaborator list - So that I can know the collaborators of a shared resource - - Background: - Given the administrator has set the default folder for received shares to "Shares" in the server - And these users have been created with default attributes and without skeleton files in the server: - | username | - | Alice | - | Brian | - And user "Brian" has created folder "simple-folder" in the server - - @issue-ocis-2260 - Scenario Outline: change the collaborators of a file & folder - Given user "Brian" has logged in using the webUI - And user "Brian" has shared folder "/simple-folder" with user "Alice" with "" permissions in the server - When the user changes the collaborator role of "Alice Hansen" for folder "simple-folder" to "" with permissions "" using the webUI - # check role without reloading the collaborators panel, see issue #1786 - Then user "Alice Hansen" should be listed as "" in the collaborators list on the webUI - # check role after reopening the collaborators panel - And user "Alice Hansen" should be listed as "" in the collaborators list for folder "simple-folder" on the webUI - And user "Alice" should have received a share with these details in the server: - | field | value | - | uid_owner | Brian | - | share_with | Alice | - | file_target | /Shares/simple-folder | - | item_type | folder | - | permissions | | - Examples: - | initial-permissions | set-role | expected-role | set-permissions | expected-permissions | - | read,update,create | Viewer | Can view | , | read,share | - | read | Editor | Can edit | , | read,update,create,delete,share | - | read,share | Custom permissions | Can view | share | read,share | - | all | Custom permissions | Can edit | update,create,delete,share | all | diff --git a/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature b/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature index 5c0a9ffa7b4..a6d0708d951 100644 --- a/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature +++ b/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature @@ -106,23 +106,6 @@ Feature: Public link share management Then a link named "Public Link" should be listed with role "Anyone with the link can view" in the public link list of resource "textfile.txt" via "simple-folder" on the webUI And a link named "strängé लिंक नाम (#2 &).नेपाली" should be listed with role "Anyone with the link can view" in the public link list of resource "textfile.txt" via "sub-folder" on the webUI - @issue-3040 @issue-3841 @issue-ocis-reva-372 - Scenario: sharing details of indirect link share in "favorites" file lists - Given user "Alice" has created folder "/simple-folder/simple-empty-folder" in the server - And user "Alice" has created a public link with following settings in the server - | path | /simple-folder | - | name | Public Link | - And user "Alice" has created a public link with following settings in the server - | path | /simple-folder/simple-empty-folder | - | name | Public Link Sub | - And user "Alice" has favorited element "simple-folder/simple-empty-folder" in the server - And user "Alice" has logged in using the webUI - When the user browses to the shared-via-link page using the webUI - Then a link named "Public Link" should be listed with role "Anyone with the link can view" in the public link list of resource "simple-folder/simple-empty-folder" via "simple-folder" on the webUI - And a link named "Public Link Sub" should be listed with role "Anyone with the link can view" in the public link list of resource "simple-empty-folder" on the webUI - When the user browses to the favorites page using the webUI - Then a link named "Public Link" should be listed with role "Anyone with the link can view" in the public link list of resource "simple-folder/simple-empty-folder" via "simple-folder" on the webUI - @skipOnOC10 @issue-product-130 Scenario: User can attempt to upload a file in public link Given user "Alice" has created file "lorem.txt" in the server diff --git a/tests/acceptance/run.sh b/tests/acceptance/run.sh index 12373509cde..e1da54ebc68 100755 --- a/tests/acceptance/run.sh +++ b/tests/acceptance/run.sh @@ -77,7 +77,6 @@ FINAL_EXIT_STATUS=0 # Example: "features/webUILogin features/webUINotifications" # or # TEST_CONTEXT: name of the suite to run -# Example: "webUIFavorites" if [ -n "${TEST_PATHS}" ] then diff --git a/tests/e2e/cucumber/features/smoke/rename.feature b/tests/e2e/cucumber/features/smoke/rename.feature new file mode 100644 index 00000000000..4cab79f2a6b --- /dev/null +++ b/tests/e2e/cucumber/features/smoke/rename.feature @@ -0,0 +1,49 @@ +Feature: rename + As a user + I want to rename resources + So I can rename resources from different locations + + Scenario: rename resources + Given "Admin" creates following user using API + | id | + | Alice | + | Brian | + And "Alice" logs in + And "Alice" creates the following folders in personal space using API + | name | + | folder | + And "Alice" creates the following files into personal space using API + | pathToFile | content | + | folder/example.txt | example text | + And "Alice" opens the "files" app + And "Alice" shares the following resource using API + | resource | recipient | type | role | + | folder | Brian | user | Can edit | + And "Alice" creates a public link for the resource "folder" with password "%public%" using the sidebar panel + And "Alice" renames the most recently created public link of resource "folder" to "myPublicLink" + And "Alice" edits the public link named "myPublicLink" of resource "folder" changing role to "Can edit" + And "Brian" logs in + And "Brian" opens the "files" app + And "Brian" navigates to the shared with me page + And "Brian" opens folder "folder" + + # rename in the shares with me page + When "Brian" renames the following resource + | resource | as | + | example.txt | renamedByBrian.txt | + And "Brian" logs out + + # rename in the public link + When "Anonymous" opens the public link "myPublicLink" + And "Anonymous" unlocks the public link with password "%public%" + When "Anonymous" renames the following resource + | resource | as | + | renamedByBrian.txt | renamedByAnonymous.txt | + + # rename in the shares with other page + And "Alice" navigates to the shared with others page + And "Alice" opens folder "folder" + When "Alice" renames the following resource + | resource | as | + | renamedByAnonymous.txt | renamedByAlice | + And "Alice" logs out diff --git a/tests/e2e/cucumber/steps/ui/shares.ts b/tests/e2e/cucumber/steps/ui/shares.ts index afc6663f49b..6eb2e122e9a 100644 --- a/tests/e2e/cucumber/steps/ui/shares.ts +++ b/tests/e2e/cucumber/steps/ui/shares.ts @@ -142,6 +142,15 @@ When( } ) +When( + '{string} navigates to the shared with others page', + async function (this: World, stepUser: string): Promise { + const { page } = this.actorsEnvironment.getActor({ key: stepUser }) + const pageObject = new objects.applicationFiles.page.shares.WithOthers({ page }) + await pageObject.navigate() + } +) + When( '{string} declines the following share(s)', async function (this: World, stepUser: string, stepTable: DataTable): Promise { diff --git a/tests/e2e/support/objects/app-files/page/index.ts b/tests/e2e/support/objects/app-files/page/index.ts index fe1a202f13a..c2c3e8de43d 100644 --- a/tests/e2e/support/objects/app-files/page/index.ts +++ b/tests/e2e/support/objects/app-files/page/index.ts @@ -1,11 +1,12 @@ import { WithMe } from './shares/withMe' import { Personal } from './spaces/personal' import { Projects } from './spaces/projects' +import { WithOthers } from './shares/withOthers' export { Public } from './public' import { Overview } from './trashbin/overview' -export const shares = { WithMe } +export const shares = { WithMe, WithOthers } export const spaces = { Personal, Projects } export const trashbin = { Overview } diff --git a/tests/e2e/support/objects/app-files/page/shares/withOthers.ts b/tests/e2e/support/objects/app-files/page/shares/withOthers.ts new file mode 100644 index 00000000000..3695725e2a0 --- /dev/null +++ b/tests/e2e/support/objects/app-files/page/shares/withOthers.ts @@ -0,0 +1,16 @@ +import { Page } from '@playwright/test' + +const sharesNavSelector = '//a[@data-nav-name="files-shares"]' + +export class WithOthers { + #page: Page + + constructor({ page }: { page: Page }) { + this.#page = page + } + + async navigate(): Promise { + await this.#page.locator(sharesNavSelector).click() + await this.#page.getByText('Shared with others').click() + } +}