From 094c65f3b70fd5601b65507edbd3227b035deebe Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi Date: Fri, 9 Dec 2022 13:58:03 +0545 Subject: [PATCH] Refactor test steps --- ...ailures-Iphone-oc10-server-oauth2-login.md | 2 -- .../acceptShares.feature | 30 +++++++++++++------ 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/tests/acceptance/expected-failures-Iphone-oc10-server-oauth2-login.md b/tests/acceptance/expected-failures-Iphone-oc10-server-oauth2-login.md index 1444b372b50..b8b7719c8b5 100644 --- a/tests/acceptance/expected-failures-Iphone-oc10-server-oauth2-login.md +++ b/tests/acceptance/expected-failures-Iphone-oc10-server-oauth2-login.md @@ -1,4 +1,2 @@ ## Scenarios from web tests run on Iphone that are expected to fail on oC10 -### [renaming a resource does not work](https://github.com/owncloud/ocis-reva/issues/14) -- [webUISharingAcceptSharesToRoot/acceptShares.feature:51](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptSharesToRoot/acceptShares.feature#L51) diff --git a/tests/acceptance/features/webUISharingAcceptSharesToRoot/acceptShares.feature b/tests/acceptance/features/webUISharingAcceptSharesToRoot/acceptShares.feature index 7caea523106..fa1b80d1249 100644 --- a/tests/acceptance/features/webUISharingAcceptSharesToRoot/acceptShares.feature +++ b/tests/acceptance/features/webUISharingAcceptSharesToRoot/acceptShares.feature @@ -9,7 +9,6 @@ Feature: accept/decline shares coming from internal users | username | | Alice | | Brian | - And user "Brian" has logged in using the webUI Scenario: reject a share that you received as user and as group member @@ -21,6 +20,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has been added to group "grp1" in the server And user "Alice" has shared folder "/simple-folder" with user "Brian" in the server And user "Alice" has shared folder "/simple-folder" with group "grp1" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page in accepted shares view And the user declines share "simple-folder" offered by user "Alice Hansen" using the webUI When the user browses to the shared-with-me page in declined shares view @@ -39,7 +39,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has been added to group "grp1" in the server And user "Alice" has shared folder "/simple-folder" with user "Brian" in the server And user "Brian" has accepted the share "simple-folder" offered by user "Alice" in the server - And the user has browsed to the personal page + And user "Brian" has logged in using the webUI When the user shares folder "simple-folder (2)" with group "grp1" as "Viewer" using the webUI And the user deletes folder "simple-folder (2)" using the webUI And the user browses to the shared-with-me page in declined shares view @@ -60,7 +60,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has shared folder "/testimage.jpg" with group "grp1" in the server And user "Brian" has accepted the share "simple-folder" offered by user "Alice" in the server And user "Brian" has accepted the share "testimage.jpg" offered by user "Alice" in the server - And the user has browsed to the personal page + And user "Brian" has logged in using the webUI When the user deletes folder "simple-folder" using the webUI And the user deletes file "testimage.jpg" using the webUI Then folder "simple-folder" should not be listed on the webUI @@ -80,7 +80,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has been added to group "grp1" in the server And user "Alice" has shared folder "/simple-folder" with group "grp1" in the server And user "Alice" has shared folder "/testimage.jpg" with user "Brian" in the server - When the user reloads the current page of the webUI + And user "Brian" has logged in using the webUI Then folder "simple-folder" should be listed on the webUI And file "testimage.jpg" should be listed on the webUI When the user browses to the shared-with-me page in accepted shares view @@ -98,7 +98,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has been added to group "grp1" in the server And user "Alice" has shared folder "/simple-folder" with group "grp1" in the server And user "Alice" has shared folder "/testimage.jpg" with user "Brian" in the server - And the user has browsed to the personal page + And user "Brian" has logged in using the webUI When the user deletes folder "simple-folder" using the webUI And the user deletes file "testimage.jpg" using the webUI Then folder "simple-folder" should not be listed on the webUI @@ -118,6 +118,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has been added to group "grp1" in the server And user "Alice" has shared folder "/simple-folder" with group "grp1" in the server And user "Alice" has shared folder "/testimage.jpg" with user "Brian" in the server + And user "Brian" has logged in using the webUI And the user has browsed to the shared-with-me page When the user unshares folder "simple-folder" using the webUI And the user unshares file "testimage.jpg" using the webUI @@ -134,7 +135,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has created folder "/simple-folder" in the server And user "Alice" has shared folder "simple-folder" with user "Brian" with "create, read, share, update" permissions in the server And user "Brian" has renamed folder "simple-folder" to "simple-folder-renamed" in the server - And the user has reloaded the current page of the webUI + And user "Brian" has logged in using the webUI When the user deletes folder "simple-folder-renamed" using the webUI Then folder "simple-folder-renamed" should not be listed on the webUI When the user browses to the shared-with-me page in declined shares view @@ -148,7 +149,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has created folder "/simple-folder/shared" in the server And user "Alice" has shared folder "simple-folder" with user "Brian" with "create, read, share, update" permissions in the server And user "Brian" has moved folder "/simple-folder (2)" to "/simple-folder/shared" in the server - And the user has reloaded the current page of the webUI + And user "Brian" has logged in using the webUI When the user opens folder "simple-folder" using the webUI And the user deletes folder "shared" using the webUI Then folder "shared" should not be listed on the webUI @@ -161,7 +162,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has created folder "/simple-folder" in the server And user "Alice" has shared folder "/simple-folder" with user "Brian" in the server And user "Brian" has renamed folder "/simple-folder" to "/simple-folder-renamed" in the server - And the user has reloaded the current page of the webUI + And user "Brian" has logged in using the webUI When the user deletes folder "simple-folder-renamed" using the webUI And the user browses to the shared-with-me page in declined shares view And the user accepts share "simple-folder-renamed" offered by user "Alice Hansen" using the webUI @@ -175,6 +176,7 @@ Feature: accept/decline shares coming from internal users Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" in the server And user "Alice" has created file "lorem.txt" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page Then file "lorem.txt" shared by "Alice Hansen" should be in "Pending" state on the webUI When the user browses to the files page @@ -185,6 +187,7 @@ Feature: accept/decline shares coming from internal users Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" in the server And user "Alice" has created file "lorem.txt" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page Then file "lorem.txt" shared by "Alice Hansen" should be in "Pending" state on the webUI When the user browses to the files page @@ -198,6 +201,7 @@ Feature: accept/decline shares coming from internal users And user "Carol" has created file "lorem.txt" in the server And user "Carol" has shared file "lorem.txt" with user "Brian" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page Then file "lorem.txt" shared by "Alice Hansen" should be in "Pending" state on the webUI And file "lorem.txt" shared by "Carol King" should be in "Pending" state on the webUI @@ -209,6 +213,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has created file "testimage.jpg" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server And user "Alice" has shared file "testimage.jpg" with user "Brian" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page in accepted shares view And the user declines share "lorem.txt" offered by user "Alice Hansen" using the webUI When the user browses to the shared-with-me page in declined shares view @@ -225,6 +230,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has created file "testimage.jpg" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server And user "Alice" has shared file "testimage.jpg" with user "Brian" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page in accepted shares view And the user accepts share "lorem.txt" offered by user "Alice Hansen" using the webUI Then file "lorem.txt" shared by "Alice Hansen" should be in "Accepted" state on the webUI @@ -241,6 +247,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has shared file "lorem.txt" with user "Brian" in the server And user "Alice" has shared file "testimage.jpg" with user "Brian" in the server And user "Brian" has declined the share "lorem.txt" offered by user "Alice" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page in declined shares view And the user accepts share "lorem.txt" offered by user "Alice Hansen" using the webUI And the user browses to the shared-with-me page in accepted shares view @@ -257,6 +264,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has created file "testimage.jpg" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server And user "Alice" has shared file "testimage.jpg" with user "Brian" in the server + And user "Brian" has logged in using the webUI And the user has browsed to the shared-with-me page When the user accepts share "lorem.txt" offered by user "Alice Hansen" using the webUI And the user browses to the files page @@ -280,6 +288,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has accepted the share "data.zip" offered by user "Alice" in the server And user "Brian" has accepted the share "lorem.txt" offered by user "Alice" in the server And user "Brian" has accepted the share "simple-folder" offered by user "Alice" in the server + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page in accepted shares view And the user batch declines these shares using the webUI | name | @@ -295,7 +304,7 @@ Feature: accept/decline shares coming from internal users Scenario: shared file status is changed to declined when user deletes the file Given user "Alice" has created file "lorem.txt" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server - And the user has reloaded the current page of the webUI + And user "Brian" has logged in using the webUI When the user deletes file "lorem.txt" using the webUI And the user browses to the shared-with-me page in declined shares view Then file "lorem.txt" shared by "Alice Hansen" should be in "Declined" state on the webUI @@ -307,6 +316,7 @@ Feature: accept/decline shares coming from internal users And the following files have been deleted by user "Brian" in the server | name | | lorem.txt | + And user "Brian" has logged in using the webUI When the user browses to the shared-with-me page in declined shares view And the user accepts share "lorem.txt" offered by user "Alice Hansen" using the webUI When the user browses to the shared-with-me page in accepted shares view @@ -324,6 +334,7 @@ Feature: accept/decline shares coming from internal users And user "Alice" has created folder "/simple-folder" in the server And user "Alice" has created folder "/simple-folder/from_Alice" in the server And user "Alice" has shared folder "/simple-folder" with user "Brian" in the server + And user "Brian" has logged in using the webUI And the user has browsed to the shared-with-me page When the user accepts share "simple-folder" offered by user "Alice Hansen" using the webUI Then folder "simple-folder" shared by "Alice Hansen" should be in "Accepted" state on the webUI @@ -342,6 +353,7 @@ Feature: accept/decline shares coming from internal users And user "Brian" has been added to group "grp1" in the server And user "Alice" has shared folder "/simple-folder" with user "Brian" in the server And user "Alice" has shared folder "/simple-folder" with group "grp1" in the server + And user "Brian" has logged in using the webUI And the user has browsed to the shared-with-me page When the user accepts share "simple-folder" offered by user "Alice Hansen" using the webUI Then folder "simple-folder" shared by "Alice Hansen" should be in "Accepted" state on the webUI