Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor issues in Makefile #69

Open
torfjelde opened this issue Mar 16, 2021 · 0 comments
Open

Some minor issues in Makefile #69

torfjelde opened this issue Mar 16, 2021 · 0 comments

Comments

@torfjelde
Copy link
Collaborator

I had to make the following changes to the setup:

  1. git clone in https://github.com/oxcsml/Rmap/blob/fdbdf5bb2c29e73c23141536926a8cf6d222545f/Makefile#L6 failed because folder already existed.
  2. It seems to me like https://github.com/oxcsml/Rmap/blob/fdbdf5bb2c29e73c23141536926a8cf6d222545f/Makefile#L7 should actually be pip install -e . dataprocessing, no? At least the current setup failed due to not finding setup.py but changing to what I suggest fixes it and make preprocess-data works just fine after.
  3. If make environment fails for some reason, then it won't be possible to execute make environemt again without removing the first line (https://github.com/oxcsml/Rmap/blob/fdbdf5bb2c29e73c23141536926a8cf6d222545f/Makefile#L5). No biggie, but might be something you want to change when making it public.

Seems like data-generation process ran without issues after fixing the above though, so super-nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant