WIP: Add clickhouse-cluster-config to omdb blueprint output #6968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
commented
Oct 31, 2024
nexus/types/src/deployment.rs
Outdated
| .collect(), | ||
| ); | ||
| let servers = BpSledSubtable::new( | ||
| BpClickhouseKeepersSubtableSchema {}, |
There was a problem hiding this comment.
Suggested change
| BpClickhouseKeepersSubtableSchema {}, | |
| BpClickhouseServersSubtableSchema {}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add diff support. Diff support is blocked on deciding whether to remove the ability to diff blueprints with inventory collections, which I feel pretty strongly we should just go ahead and do. I'd do that in a separate PR that this would then build upon.
Fixes #6941