Delay starting zone-network-service until in.ndpd is online #6982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition between being able to configure an addrconf address on an interface, and the NDP daemon starting up. If they start in parallel, there is a chance that configuring network interfaces will fail resulting in a broken zone. There is a fix to implement better handling of the conflict in stlouis but we should also just wait for the NDP service to come up before attempting to configure interfaces. Fixes #6947 (along with stlouis#650)
rcgoodfellow
approved these changes
Nov 2, 2024
|
Are we sure the OS bug is fixed, or will this just paper over it and we won't know for sure? |
karencfv
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Thanks for the fix!
@jclulow I think the OS fix is this one https://code.oxide.computer/c/illumos-gate/+/477
My perspective is that this is the true fix, with the OS change resolving a race condition that shouldn't be invoked any more. I've spun up the control plane several times with just the OS change in place and not seen any zones fail to come up, but let's defer integrating this PR until after the next dogfood update just to add confidence in that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition between being able to configure an
addrconf address on an interface, and the NDP daemon starting up.
If they start in parallel, there is a chance that configuring
network interfaces will fail resulting in a broken zone. There
is a fix to implement better handling of the conflict in stlouis
but we should also just wait for the NDP service to come up before
attempting to configure interfaces.
Fixes #6947 (along with stlouis#650)