Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdP certificate rotation #6976

Open
augustuswm opened this issue Oct 31, 2024 · 3 comments
Open

IdP certificate rotation #6976

augustuswm opened this issue Oct 31, 2024 · 3 comments

Comments

@augustuswm
Copy link
Contributor

Currently we do not have support for handling certificate rotations (both for certificates issued by the IdP and the SP).

The current plan is to support a create + delete rotation mechanism so that operators can create a new IdP configuration, perform testing to confirm it works, and then deleting the old configuration. There are a few pieces missing to be able to support this:

  1. Add support for deleting an IdP configuration.
  2. The name of the IdP configuration is a unique value that is used in multiple places
    • ACS Url, login elements for the silo users (urls and UI elements)
    • As a result (assuming delete was implemented) this means that certificate rotation is an outward visible change to silo users
    • Ideally to a silo user there would be no visible effect of a certificate rotation
  3. If multiple IdP configurations are allowed to have the same ACS Url, how do we decide which to pick.

Part of this exercise should be mapping out the steps that we expect an operator to take when rotating certificates. I'll work on putting together some examples based on the IdPs we currently support.

@augustuswm
Copy link
Contributor Author

augustuswm commented Nov 1, 2024

Silo IdP configurations are annotated as SP-X
IdP configurations (sometimes name applications) are annotated IdP-X

In all examples it is assuming there is a valid configuration pair already setup on the silo (SP-A, IdP-A)

IdP certificate rotation

Google Workspace (5 year cert)

  1. Create new key + cert in Google Workspace
  2. Create new application IdP-B in Google Workspace
  3. Create new IdP configuration SP-B in silo with metadata from IdP-B
  4. Update IdP-B with parameters from SP-B
  5. Test that login via SP-B works
  6. Update IdP-A to use new certificate and parameters from SP-B
  7. Delete SP-A
  8. Delete IdP-B

Keycloak (10 year cert)

  1. Create new key in Keycloak
  2. Create a new client IdP-B in Keycloak
  3. Create new IdP configuration SP-B in silo with metadata from IdP-B
  4. Update IdP-B with parameters from SP-B
  5. Disable old key in Keycloak and test that login via SP-B works. Note that while the old key is disabled, users will not be able to log in via SP-A. This is a limitation in Keycloak as it does not permit selecting a signing key per client.
  6. Update IdP-A to use parameters from SP-B
  7. Delete SP-A
  8. Delete IdP-B

Duo (13?? year cert)
I have not yet found an option for manually rotating a signing key. Assumption may be that users are able to update their IdP metadata as new certificates are added. Notably the certificate we are given is valid for ~13 years (expires 01/2038).

Okta (10 year cert)

  1. Create new application IdP-B in Okta
  2. Create new IdP configuration SP-B in silo with metadata from IdP-B
  3. Update IdP-B with parameters from SP-B
  4. Test that login via SP-B works
  5. Delete SP-A (Certificates are bound to applications so we can not port the known working settings from IdP-B)
  6. Delete IdP-A

Very similar flows would be needed for handling expired SP certificates. After walking through these four, all seem to operate under the assumption that the SP can update it's IdP metadata in place to accept new certificates. I still think we should consider allow updates to ease the process for operators and allow us to avoid trying to solve points #2 and #3 above. I'm not sure that the create + delete method provides more protection from lockout than a create + update in place does. While it would be more work, implementing something like revision control over IdP configuration settings would provide both in place updates and allow for options around rollback.

@augustuswm
Copy link
Contributor Author

Another alternative would be to not allow mutations create/update/delete against the silo you are currently authenticated against. This ensures that the user always has a working silo.

@davepacheco
Copy link
Collaborator

CC @askfongjojo @morlandi7 we probably need to talk about prioritizing this, maybe at the product roundtable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants