Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ClickHouse bools and disable sparse serialization #6997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use ClickHouse bools and disable sparse serialization #6997

wants to merge 1 commit into from

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Nov 5, 2024

@bnaecker
Use ClickHouse bools and disable sparse serialization
afa3237 
- Use `Bool` data type in the `oximeter` database tables. Fixes #6994.
- Disable "sparse serialization" optimization for ClickHouse columns,
  which are unlikely to help us an use an undocumented data format. This
  turns off sparse serialization for test and deployed versions of
  ClickHouse, both single-node and replicated. Fixes #6995.
karencfv
karencfv approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@karencfv karencfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It just seems like you need to run the tests with EXPECTORATE=overwrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karencfv karencfv karencfv approved these changes

@andrewjstone andrewjstone Awaiting requested review from andrewjstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bnaecker @karencfv