Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search geo jurisdiction on more fields : zipcode, parent geo area name... #253

Open
mdutoo opened this issue Aug 31, 2015 · 1 comment
Open

Comments

@mdutoo
Copy link

mdutoo commented Aug 31, 2015

Search is now only done on (cached, tokenized) geo:name.

Later, we could also allow search on:

  • zipcode (or other geo area field, which ones ?), by adding it to tokens, by using instead of tokenize(name) tokenize(dcResource) which applies tokenize(name) on a collection of conf'd fields
  • names of parent geo areas, by unencoding & splitting them from their URIs gotten from dcResource.get("oanc:ancestors")
  • other fields of parent geo areas, by getting them from the cache BUT this requires a getCachedOrUpdateCacheIfOlderThan(cacheRebuildStartTime) lazy cache access & filling approach (or a two-pass cache building algo, or getting them from Datacore but this is way too costly).

Don't do that before agreeing on the future of the current cache archi #236

Note that before, search was done on odisp:name, which allowed search on zipcode. But this has been changed because when users entered a country (ex. "france") as search input, it came with a heavy performance cost since ALL french geo areas (which all contain "France" in their display name) had to be scanned and sorted (in order to put the actual France geo area on top, otherwise it could never be found).

@mdutoo mdutoo changed the title Model Governance - frozenMixins Issue tu be reused Aug 31, 2015
@mdutoo mdutoo changed the title Issue tu be reused Issue to be reused 253 Aug 31, 2015
@mdutoo mdutoo changed the title Issue to be reused 253 Further geo search jurisdiction : also on zipcode, parent geo area name... Sep 1, 2015
@mdutoo mdutoo changed the title Further geo search jurisdiction : also on zipcode, parent geo area name... Search geo jurisdiction on more fields : zipcode, parent geo area name... Sep 1, 2015
ilucatero added a commit that referenced this issue Sep 1, 2015
…:name data; this removes the search by zip code, but avoids performance issues when searching by (not filtering by!) country -in odisp ALL cities and regions contain also the country : 'ville (zip) - country'.
@mdutoo
Copy link
Author

mdutoo commented Oct 6, 2015

Be careful, the workflow of selection of zipcode then city or conversely isn't simple either from a functional point of view or from a technical one (jsx select2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant