Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 45 compatibility #149

Closed
peterloeffler opened this issue Sep 14, 2023 · 18 comments · Fixed by #150
Closed

Gnome 45 compatibility #149

peterloeffler opened this issue Sep 14, 2023 · 18 comments · Fixed by #150

Comments

@peterloeffler
Copy link

Gnome 45 breaks retro-compatibility with older versions by moving to ESM modules.
In order for argos to run on Gnome >= 45 there are some guidelines to stick to:
https://gjs.guide/extensions/upgrading/gnome-shell-45.html

Would be nice to be able to use argos also in the future!

@mwilck
Copy link
Collaborator

mwilck commented Sep 22, 2023

I'll look into this hopefully soon. I've started looking into GNOME 45 for the other extension I'm maintaining, projecthamster/hamster-shell-extension.

I think it's doable but not easy. Also, as soon as GNOME 45 support is added, support for all earlier GNOME version must be dropped (this is inevitable this time). So we'll likely need separate branches.

@mwilck
Copy link
Collaborator

mwilck commented Sep 26, 2023

I have pushed my GNOME 45 branch to WIP-gnome-45 now. It works ok-ish for me. This branch works only with GNOME shell 45. Screen shots of a few Argos programs:

Screenshot from 2023-09-26 22-31-44

Screenshot from 2023-09-26 22-32-43

Screenshot from 2023-09-26 22-32-09

Disabling and re-enabling the argos extension works as well.
Please provide feedback.

@marianrh
Copy link

I tested branch WIP-gnome-45 on the Ubuntu 23.10 beta. In my (simple) use case everything works as expected. Thank you very much for your work!

@peterloeffler
Copy link
Author

Tested the branch on OpenSUSE Tumbleweed.
For me everything works.
Great! Thanks a lot for your work!

@ratboy666
Copy link

Testing on Fedora 39 beta. So far, so good. Thanks!

@Janhouse
Copy link

Seems to work fine. Please consider merging. Arch just switched to Gnome 45, I guess a lot more people will need it.

@marinierb
Copy link

marinierb commented Oct 13, 2023

Works for me on "Manjaro unstable".

Thank you so much for this!

@mwilck mwilck linked a pull request Oct 16, 2023 that will close this issue
@javadr
Copy link

javadr commented Nov 6, 2023

Thanks @mwilck. Works on Manjaro 23.1.0 Vulcan too. (Gnome 45)

@Toby-Haynes
Copy link

Toby-Haynes commented Nov 14, 2023 via email

@dvogel
Copy link

dvogel commented Nov 17, 2023

Works for me on both Debian Trixie and Ubuntu 23.10.

@Coda-Coda
Copy link

Coda-Coda commented Dec 7, 2023

This works for me - thank you very much!!! I only use simple features of argos.
On NixOS (unstable channel). Gnome Shell 45.1.

@nafg
Copy link

nafg commented Dec 28, 2023

Is this going to be mainlined?

@PaulCrisan
Copy link

Works on Manjaro. Thank you very much!

@moritztim
Copy link

For the record:
13. Dec. 2023 Dario.Lesca:

This new version https://github.com/p-e-w/argos/tree/WIP-gnome-45 work on Fedora 39 with Gnome 45.
Also the standard Fedora 39 package "gnome-shell-extension-argos-3^20230404gite2d68ea-3.fc39.noarch" work.

@moritztim
Copy link

I think it's doable but not easy. Also, as soon as GNOME 45 support is added, support for all earlier GNOME version must be dropped (this is inevitable this time). So we'll likely need separate branches.

@mwilck I can't find but I read somewhere that you can now publish separate versions on extensions.gnome.org now, in case you didn't already know

@mwilck
Copy link
Collaborator

mwilck commented Jan 10, 2024

@mwilck I can't find but I read somewhere that you can now publish separate versions on extensions.gnome.org now, in case you didn't already know

That has been possible for years. But we can't publish on extensions.gnome.org.
Have a look at #108, in particular @p-e-w's comments.

Here on GitHub, it's mainly a question which GNOME version the master branch should support. The majority of users here would vote for GNOME 45. But it's natural that GNOME 45 users find this issue and #150, whereas users of older GNOME versions (of LTS Linux distros) have no need to raise their voice here. If we merge #150 today, we may get a lot of angry "argos is suddenly broken" reports by these users.

OTOH, GNOME 45 has been released almost 4 months ago, so I guess we shouldn't wait much longer...

@moritztim
Copy link

Wow that sucks.

@real-or-random
Copy link

OTOH, GNOME 45 has been released almost 4 months ago, so I guess we shouldn't wait much longer...

I think #150 should be merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.