Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally overrides console.warn causing errors if string not passed #71

Open
space-nuko opened this issue May 29, 2023 · 1 comment
Open

Comments

@space-nuko
Copy link

The global override of console.warn assumes the argument passed is a string but this isn't necessarily the case. It crashes my whole app since I have log statements with different argument types

svelte-markdown.js?v=b129818a:53 Uncaught (in promise) TypeError: message.includes is not a function
    at console.warn (svelte-markdown.js?v=b129818a:53:17)
    at updateAttribute (ComfyProperties.svelte?t=1685400662407:2268:11)
    at Array.change_handler (ComfyProperties.svelte?t=1685400662407:2385:38)
    at Textbox.change_handler (ComfyProperties.svelte?t=1685400662407:1564:36)
    at chunk-PUOMPBAM.js?v=a23c27b8:1014:12
    at Array.forEach (<anonymous>)
    at chunk-PUOMPBAM.js?v=a23c27b8:1013:25
    at handle_change (Textbox.svelte:761:3)
    at $$self.$$.update (Textbox.svelte:987:7)
    at update (chunk-PUOMPBAM.js?v=a23c27b8:1106:8)
@khromov
Copy link

khromov commented Jul 9, 2023

Can you show a reduced example that triggers this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants