Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in a winrm client #37

Open
kke opened this issue Jun 18, 2020 · 0 comments
Open

Allow passing in a winrm client #37

kke opened this issue Jun 18, 2020 · 0 comments

Comments

@kke
Copy link

kke commented Jun 18, 2020

I think plenty of people are using this together with the masterzen/winrm package, which is a dependency of this package too, so there's already code for setting up the winrm client.

The winrmcp package could accept an existing winrm.Client instead of having to set up a new one through winrmcp.New()

Because Winrmcp{}'s config and client are unexported, you can't do something like winrmcp.Winrmcp{client: existingclient, config: winrmcp.Config{....}}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant