Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contributing] - for forked pull requests, either support or disable pact broker publishing #1344

Open
YOU54F opened this issue Jan 21, 2025 · 0 comments

Comments

@YOU54F
Copy link
Member

YOU54F commented Jan 21, 2025

When contributing to pact-js, a user will submit a pull request, which will trigger several jobs.

Some of these jobs will fail, as the forked repository does not have access to repository secrets, this is a sensible and preferred approach to security, however it does leave us in a predicament when it comes to accepting contributions.

As some of the jobs will always fail, the test completion check will always fail. This is a required status check, and pre-requisite for merging, with no current way to circumvent.

We should consider how we can support external contributor workflows

  1. Disable jobs which require publishing if external org is not pact-foundation
    • stops external contributors being able to test anything that touches a broker
  2. Disable publishing steps only for examples which do so
    • stops external contributors being able to test anything that touches a broker
  3. Hard code PACT_BROKER_TOKEN secret and export to env, if external org is not pact-foundation
    • At least allows users/maintainers to test/confirm behaviour for anything that touches a broker
  4. On contributor workflows, only run publishing steps on linux machines and use docker based locally running pact-broker
    • would allow test of basic_auth based flows which are unsupported by the PactFlow broker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant