Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pacticipant names be case insensitve? #66

Open
canny bot opened this issue Jun 26, 2024 · 4 comments
Open

Should pacticipant names be case insensitve? #66

canny bot opened this issue Jun 26, 2024 · 4 comments

Comments

@canny
Copy link

canny bot commented Jun 26, 2024

It would be awesome if either:

  1. Pacticipant names were case insensitve
    or
  2. The broker warned when publishing or retrieving a pact if the pacticipant name differs only in case from another
    This was indirectly suggested by Subrahmanyam Rentala on slack:
    At the consumer side I provided the provider name as : ABc and at the provider side it was ABC, and again error was not user friendly to investigate

https://pact.canny.io/admin/board/feature-requests/p/should-pacticipant-names-be-case-insensitve

Copy link
Author

canny bot commented Jun 26, 2024

This issue has been linked to a Canny post: Should pacticipant names be case insensitve? 🎉

@YOU54F
Copy link
Member

YOU54F commented Jun 27, 2024

Dmitry Munda - September 8, 2021

same goes maybe with tags

@YOU54F
Copy link
Member

YOU54F commented Jun 27, 2024

Subrahmanyam Rentala - September 8, 2021

Its a simple mistake we do, but would be nice to have an appropriate error handling, or else it would be difficult to troubleshoot the issue.

@YOU54F
Copy link
Member

YOU54F commented Jun 27, 2024

Beth - September 25, 2021

There is support for case insensitive resource name matching in the broker, but it's not supported everywhere, and I wouldn't recommend using it. I've been meaning to deprecate support for that actually, as I think it could easily lead to bugs. Adding a "did you mean..." kind of output in the output from the pacts for verification response may be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant