Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release description into kinetic and melodic #2

Closed
wxmerkt opened this issue Dec 19, 2018 · 10 comments
Closed

Release description into kinetic and melodic #2

wxmerkt opened this issue Dec 19, 2018 · 10 comments

Comments

@wxmerkt
Copy link

wxmerkt commented Dec 19, 2018

Hi guys,
We are interested in starting to use the description for planning and unit testing - and being able to install it directly from binaries would be fantastic.

We are very happy to help with release etc. if desired.

Best wishes,
Wolfgang

@v-lopez
Copy link
Contributor

v-lopez commented Dec 19, 2018

Sure thing, we'll take a look this week, it should be pretty straightforward.

@wxmerkt
Copy link
Author

wxmerkt commented Dec 19, 2018

Thank you for the swift response, this is awesome!

@v-lopez
Copy link
Contributor

v-lopez commented Dec 20, 2018

We're working on it, a lot of dependencies need to be released.

For melodic, at least one branch of the dependency tree is out of our control: orocos/rtt_ros_integration#115

@wxmerkt
Copy link
Author

wxmerkt commented Dec 20, 2018

Hi @v-lopez,
Would it work for just releasing the talos_description - without the talos_robot etc. packages (which are only needed on the physical robots anyway)? From a quick scan the dependency tree appears to be:

talos_description
    rostest
    urdf_test
    talos_description_inertial
        xacro
    talos_description_calibration
        xacro

All of these are already released :-)

Thanks!
Wolfgang

@v-lopez
Copy link
Contributor

v-lopez commented Dec 20, 2018

Do you know if there's a standard procedure for releasing a single package? Or should I just edit the gbp files?

@wxmerkt
Copy link
Author

wxmerkt commented Dec 20, 2018

In the rosdistro entry you can specify which packages you'd like. For an example see here:

https://github.com/ros/rosdistro/blob/940f878c830b0fdbd6964b42434979dd2837c325/melodic/distribution.yaml#L5386-L5397

@olivier-stasse
Copy link

Dear Wolfgang,
We have packaged talos-robot in an apt-repository for various distros:
http://robotpkg.openrobots.org/rbulk/robotpkg-wip/wip/talos-robot/index.html#talos-robot-1.0.2

The problem is the license. As it is Propietary we are conservative and only providing it through a private repo protected by a password. In the frame of Memmo we can, I guess, provide it to you.

For kinetic we can provide the full simulation packages with gazebo on kinetic.
Best,
Olivier.

@v-lopez
Copy link
Contributor

v-lopez commented Dec 20, 2018

I've requested the release of talos_description as suggested.

ros/rosdistro#19805
ros/rosdistro#19806

Regarding the license, we'll review it, by default we make everything proprietary, but we'll review the software we've made open source.

@wxmerkt
Copy link
Author

wxmerkt commented Dec 20, 2018

Thank you very much @v-lopez for the speedy release :-)

Dear Olivier,
Thank you very much for the offer - I think we will come back to you on this for Memmo around the time of the winter school. For now we are good with source of the description as in this repository - or the released binaries - for planning. For simulation next spring we'll be in touch.

Happy holidays,
Wolfgang

@wxmerkt wxmerkt closed this as completed Dec 22, 2018
@v-lopez
Copy link
Contributor

v-lopez commented Jan 10, 2019

Actually the proper way for ignoring packages is described here: https://answers.ros.org/question/66545/to-ignore-some-pkgs-upon-release-by-bloom/

An example can be seen here: https://github.com/ros-gbp/moveit-release

My last release was pushed back for this reason, I'm resubmitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants