Initial chat version #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
paulgoetze
force-pushed
the
chat
branch
3 times, most recently
from
56ce90e
to
e2ab06f
Compare
|
@janlelis I still fixed some smaller layout & style issues, and I think it should be usable now. Could you do another review of the changes, please? |
in order to hide tooltip when not hovering anymore. (The tooltip stayed visible e.g. when en/disabling the camera)
instead of utc integer timestamp
Else the the avatar icon in the party & stage appears to be slightly smaller than the buttons next to it (on top of dark video images)
|
FYI: this branch is now rebased on top of tag v1.1.0 (beb2432) so that we can test it on staging already without the issues we still experience on The chat branch on top of main is available in the chat-to-main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a chat and avatar symbols (including peer colors based on the peer id) so that people in the chat can be recognized without choosing a name.