Pass room names in lowerCase to fix #89 #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the suggestion! I can understand the problem and I think I am slightly in favor of switching to case-insensitve room names. I have one remark / side-node (it's kind of offtopic to this PR, but somewhat relevant): I have the idea of changing the current auto-generated room names from the UUID-like naming schema to shorter tokens, a little bit like the YouTube IDs. The great thing if we keep the current case-sensitive room IDs would be that the short tokens could be even shorter, because single characters carry more information. What do all think about this? @farao @KopierKatze @paulgoetze @juwi |
|
Does anyone has an opinion here? :) |
|
Closing as not actionable and to be discussed in #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #89, not sure if wanted from a product perspective though - as described in the issue it makes some users wonder "why this software doesn't work", but it also kinda increases the possibility for name-clashes of
roomIds