Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyright type checking seems to be unused. mypy still being used. #5537

Closed
pygeek opened this issue Jul 31, 2024 · 1 comment
Closed

pyright type checking seems to be unused. mypy still being used. #5537

pygeek opened this issue Jul 31, 2024 · 1 comment

Comments

@pygeek
Copy link

pygeek commented Jul 31, 2024

We added pyright in 3.0.3 (see: #5457), but mypy is still being used for type checking https://github.com/pallets/flask/blob/main/tox.ini#L29-L32, and pyright is not.

If this was an intentional change of type checkers, then would expect that mypy be completely removed, and pyright be the command run in tox typing.

It should be noted, however, that running pyright yields 90 errors (71 tests/19 src). Is there an upgrade path or was this an oversight?

Environment:

  • Python version:
  • 3.12
  • Flask version:
  • 3.0.3
@davidism
Copy link
Member

fixed in #5620

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants