Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit balanceDelta in ModifiedLiquidity event #16

Open
chefburger opened this issue Sep 2, 2024 · 0 comments
Open

emit balanceDelta in ModifiedLiquidity event #16

chefburger opened this issue Sep 2, 2024 · 0 comments

Comments

@chefburger
Copy link
Contributor

Current "MintPosition" event doesn't provide information about how many token0/token1 need to be settled by positionManager for the on-going action.

Consider update to

    /// @notice Emitted when liquidity is modified
    /// @param tokenId the tokenId of the position that was modified
    /// @param liquidityChange the change in liquidity of the position
    /// @param delta the total balance delta of the caller of modifyLiquidity.
    /// @param feesAccrued the fees collected from the liquidity change
    event ModifyLiquidity(uint256 indexed tokenId, int256 liquidityChange, BalanceDelta delta, BalanceDelta feesAccrued);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant