-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Python 3.13 support #58734
Comments
HI, just curious if there has been any progress getting pandas running on 3.13. I built the JIT enabled version of python 3.13 on windows and went to try it with a number of internal tools but ran into build problems trying to get pandas package installed on 3.13. It seems to fail during the numpy portion of the build. Here is the console output from pip. Apologies if this does not belong here or I have made some other major oversight.
|
I can't help you with the compiling numpy part, but I just wanted to point out that you can install numpy nightlies, which should have python 3.13 wheels available.
|
Hey, thanks for taking the time to reply. My memory is a little hazy on this now as it was a few weeks back but I believe I tried that approach and was able to get standalone numpy to build using a cherrypicked version but when I went on to and tried to install pandas and requested that it not resolve dependencies (so to use my just built version of numpy) I recall that it seemed to ignore that option and still tried to build whatever specific version of numpy it wanted. It's certainly possible I fudged a CLI option or am misremembering something. |
Hey folks! I'm planning to spend time on fixing any issues related to the new 3.13 free threaded build of CPython in the upcoming weeks. I've already started testing
(This is all tested with the nightly NumPy and Cython wheels) I'll start investigating further issues that might be there and let everyone know about my progress. I'd also love to talk to anyone who might be trying this out as well, so that we can collaborate better on this effort. One remaining question: Should I open a new tracking issue for issues specifically related to free threading or should I use this one? |
Hi @lysnikolaou, Thanks for working on this. I am currently working on fixing regular Python 3.13 test failures in #58776. I'm down to 9 failures there.
Qt is probably not too important here, but if you're able to investigate
Please do, it's probably better to separate the general 3.13 compatibility issues from the free threading stuff P.S. |
Hey @lithomas1! Happy to collaborate on this!
Great! The rest of the failures appear to be changes in error messages, so should we expect to get that PR in relatively soon?
Agreed. I'll try to dive into pandas-specific issues first and only later spend time on PyQT if it absolutely necessary. It might make sense for us to skip these tests PyQT related tests when PyQT is not installed.
I'll open a new tracking issue soon.
No, I haven't tried that out. |
Oops, I forgot to finish my sentence Other than that, a PR adjusting the error messages would be nice. |
I can check that after we're done with the pandas extension modules themselves, sure.
I'll get started on that then. |
x-ref pandas-dev#58734 Co-authored-by: Thomas Li <[email protected]>
* ENH: Fix Python 3.13 test failures & enable CI x-ref #58734 Co-authored-by: Thomas Li <[email protected]> * Cast npy_intp to int to fix Windows CI --------- Co-authored-by: Thomas Li <[email protected]>
It would be awesome for users and maintainers of downstream dependencies if wheels could be uploaded to PyPI directly after the first release candidate (currently targeted for Tuesday, 2024-07-30). |
Thanks a lot for your work on this 🙏! Sorry to be the bearer of bad news, but it seems like the Python 3.13 wheel build has been failing for a few days, I created a separate issue about this #59372 . |
3.13 rc1 is released! This means the ABI is stable and wheels can be uploaded to PyPI. Tracking for cibuildwheel: pypa/cibuildwheel#1949 What would be fastest feasible course to get wheels on PyPI? Would a 2.2.3 release with 3.13 wheels be possible? |
3.13 support will probably land as part of the pandas 3.0 release (probably Fall 2024) |
Thanks! If it can't be backported to Pandas 2.x, I would love for some 3.0 pre-releases to include it as well. cibuildwheel now uses the latest Python |
When testing the wheels, about 80 of these types of errors happen, on Python 3.13 only:
Any idea what causes these? See #59401 for the full logs. |
It seems similar errors are going on on the main branch (example). Edit: It seems this was the last passing wheel build, which ran on July 26th. It did include successful Python 3.13 wheel builds. |
Opened an issue for the error above: |
NumPy 2.1.0rc1 is now released with Python 3.13 support. It could be added as a required dependency when using Python 3.13.
|
@mroeschke do you think there's any way to get Python 3.13 wheels on PyPI relatively soon, at least before the stable Python 3.13 release? Since there are many downstream dependencies waiting on Pandas before being able to update workflows, tests and wheels. |
We have a nightly wheel with 3.13 support here: https://anaconda.org/scientific-python-nightly-wheels/pandas |
* ENH: Fix Python 3.13 test failures & enable CI x-ref pandas-dev#58734 Co-authored-by: Thomas Li <[email protected]> * Cast npy_intp to int to fix Windows CI --------- Co-authored-by: Thomas Li <[email protected]>
* ENH: Fix Python 3.13 test failures & enable CI x-ref pandas-dev#58734 Co-authored-by: Thomas Li <[email protected]> * Cast npy_intp to int to fix Windows CI --------- Co-authored-by: Thomas Li <[email protected]>
* ENH: Fix Python 3.13 test failures & enable CI x-ref pandas-dev#58734 Co-authored-by: Thomas Li <[email protected]> * Cast npy_intp to int to fix Windows CI --------- Co-authored-by: Thomas Li <[email protected]>
2.2.3 released with wheels supporting 3.13 so I think we can close this issue |
Python 3.13b1 is out, which means its time to start looking into Python 3.13 support!
Steps
The text was updated successfully, but these errors were encountered: