-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Fix armv7 build #59906
BLD: Fix armv7 build #59906
Conversation
#define PY_SSIZE_T_CLEAN | ||
// clang-format off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove these clang-format comments now too (I assume they were flagging the multiple includes of the header)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not. clang-format
changes the order of imports here, so without the comment the change would be reverted by pre-commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK...that makes sense. Thanks.
I see CI is broken now but I believe that's unrelated
CI should be fixed - merge main to kickoff the builds. |
Great thanks for the contribution @cdce8p If you are interesting in further contributions, it might be a nice follow up to check all of the files we have and make sure that the Python include / macro always comes first. Probably worth turning off the clang-format feature that reorders includes to ensure that |
I might be able to take a look at that. No promises though 😅 @WillAyd What is the process to get this fix backproted to |
So the scope of this is that it prevents running pandas on 3.13 on musl platforms right? The 2.2 branch I think is closed at this point. We are in the process of backporting a ton of things to 2.3, but I think also want to be very cognizant of what else goes there, because we have already spent a ton of time on that with very limited resources. @lithomas1 @jorisvandenbossche @rhshadrach might also have opinions |
It prevent building pandas |
Given that this is a tiny diff, lets at least backport this to 2.3.x |
@meeseeksdev backport to 2.3.x |
If that is the case, would it be good to add a note about this in the 2.3.0 whatsnew file? |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.