Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add test for pd.Timestamp DST transition #60346

Merged
merged 1 commit into from
Nov 17, 2024
Merged

TST: Add test for pd.Timestamp DST transition #60346

merged 1 commit into from
Nov 17, 2024
+11 −0

Conversation

KevsterAmp
Copy link
Contributor

rhshadrach
rhshadrach approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Needs Tests Unit test(s) needed to prevent regressions hashing hash_pandas_object Timestamp pd.Timestamp and associated methods labels Nov 17, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Nov 17, 2024
@rhshadrach rhshadrach merged commit 7fe270c into pandas-dev:main Nov 17, 2024
63 checks passed
@rhshadrach
Copy link
Member

Thanks @KevsterAmp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
hashing hash_pandas_object Needs Tests Unit test(s) needed to prevent regressions Timestamp pd.Timestamp and associated methods
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: arithmetic can break equality-hash invariant for Timestamp during DST transition
2 participants
@KevsterAmp @rhshadrach