ENH: removed median percentile to be always included in describe GH #60550 #60557
+35
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes pandas-dev#60550 - median percentile is default when a blank list of percentiles is passed
mroeschke
reviewed
Dec 13, 2024
mroeschke
reviewed
Dec 13, 2024
|
@mroeschke I don't think a separate test is needed as the core functionality remains the same. |
We should have had a test that when you specify Since we're changing the behavior, I think a test needs to be added. |
|
@mroeschke @rhshadrach thanks for the feedback, the tests are now added. |
|
@mroeschke, I hope you were able to look into this and merge the PR? |
asishm
reviewed
Dec 23, 2024
Co-authored-by: Asish Mahapatra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.describe(percentiles = [0.25])returns 25th- and 50th-percentile #60550pandas/tests/reductions/test_describe_ndframe.pyAdded type annotations to new arguments/methods/functions.NAdoc/source/whatsnew/v2.3.0.rstfile if fixing a bug or adding a new feature.