-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None of the --log-level
cli options work
#121
Comments
This this is a custom job here: https://github.com/pangeo-forge/pangeo-forge-runner/blob/main/pangeo_forge_runner/commands/base.py#L44C6-L57 Will look into later after some meetings |
welp, this didn't mute it either |
Even this didn't work 😠 @dataclass
class ShutUpAndStoreToZarr(StoreToZarr):
def expand(self, pcoll: beam.PCollection) -> beam.PCollection:
rechunking_logger = logging.getLogger('pangeo_forge_recipes.rechunking')
rechunking_logger.setLevel(logging.CRITICAL)
return pcoll | StoreToZarr(store_name=self.store_name, combine_dims=self.combine_dims, target_chunks=self.target_chunks) |
The default logging config is for traitlets, and anything using I remember fiddling with it in #65, which may be of use :) |
Right, what we're really after in this issue (which isn't explicit) is how to turn off logs in the default logging in recipe transforms b/c @sbquinlan was thinking they are causing issues with some grpc calls (at least I think that's what he was saying in DMs) |
Actually I think the explicit problem that I described at the start is good for this issue. The traitlet option for setting the log level does not seem to work at all. Is
Is this saying that, when running locally, Bake.log_level should propagate to the workers? That's cool, but I'm not sure I saw that happening. It's unclear from your PR how that was tested for me to have a workaround here. |
What I did:
I wanted to change the default log level. I saw some properties on
BaseCommand
in the source so I looked at the help to see how to set them:Cool I'll set that:
What happened:
I tried
--log-level=0
,--Application.log_level=WARN
and got more or less the same resultWhat I expected
Bake accepts the log level config and does not INFO log.
The text was updated successfully, but these errors were encountered: