Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS support? #16

Open
UladzimirTrehubenka opened this issue Sep 24, 2019 · 15 comments
Open

TLS support? #16

UladzimirTrehubenka opened this issue Sep 24, 2019 · 15 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed long term It's going to be a long-term work proposal Proposal for this repo
Milestone

Comments

@UladzimirTrehubenka
Copy link

Is TLS support planned?

In accordance with tidwall/evio#28 there are no easy way to implement it:

The problem is in standard Go TLS implementation. It doesn't have an event-based idea mechanism and actually it can block calls like Reader.Read() during handshake, what is actually not accurate by the io.Reader contract.

Looks like custom TLS implementation is required for this.

@panjf2000
Copy link
Owner

@UladzimirTrehubenka
It's no plan for now, but I will keep investigating it and support TLS if it is possible.

@panjf2000 panjf2000 added the enhancement New feature or request label Sep 29, 2019
@panjf2000 panjf2000 self-assigned this Oct 11, 2019
@panjf2000 panjf2000 added long term It's going to be a long-term work proposal Proposal for this repo labels Oct 20, 2019
@jingc1413
Copy link

hi, brother, When can the tls/dtls be supported?
wait your messge

@ivanjaros
Copy link

yeah, without tls this is quite useless these days where even services in a private network use encryption. tls is simply a must, no matter which protocol you're using these days, there's no way around it.

@chowyu08
Copy link

does now support tls?

@chowyu08
Copy link

什么时候支持tls

@HeisenbergV
Copy link

请问tls还会支持吗

@panjf2000
Copy link
Owner

Sorry, I don't have a particularly convincing idea of how to implement TLS in gnet at the present stage, and I don't have much time to do this at the moment, it'd be great if anyone could take this job and open a PR for it, contribute code or provide some insightful thoughts.

@panjf2000 panjf2000 added the help wanted Extra attention is needed label Sep 14, 2021
@vikassandhu999
Copy link

Sorry, I don't have a particularly convincing idea of how to implement TLS in gnet at the present stage, and I don't have much time to do this at the moment, it'd be great if anyone could take this job and open a PR for it, contribute code or provide some insightful thoughts.

Though I don't have much experience with TLS implementations but If someone is willing to take the charge of the job, I can assist them.

@panjf2000 panjf2000 pinned this issue Sep 27, 2021
@panjf2000 panjf2000 added this to the v2 milestone Oct 7, 2021
@panjf2000 panjf2000 modified the milestones: v2, Long term Jan 3, 2022
@seymourtang
Copy link

seymourtang commented Mar 23, 2022

Here is an example on how to implement TLS in gnet:gnet TLS

@rock59
Copy link

rock59 commented Feb 25, 2023

s2n-tls is a small, modern, secure and fast TLS implementation developed and used by AWS. It provides posix-like api so it seems easy to integrate it in gent for developers who dont mind using cgo.

Copy link

This issue is marked as stale because it has been open for 30 days with no activity.

You should take one of the following actions:

  • Manually close this issue if it is no longer relevant
  • Comment if you have more information to share

This issue will be automatically closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 26, 2024
@panjf2000 panjf2000 removed the stale label Sep 26, 2024
Copy link

This issue is marked as stale because it has been open for 30 days with no activity.

You should take one of the following actions:

  • Manually close this issue if it is no longer relevant
  • Comment if you have more information to share

This issue will be automatically closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Oct 27, 2024
@panjf2000 panjf2000 removed the stale label Oct 27, 2024
Copy link

This issue is marked as stale because it has been open for 30 days with no activity.

You should take one of the following actions:

  • Manually close this issue if it is no longer relevant
  • Comment if you have more information to share

This issue will be automatically closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Nov 26, 2024
@panjf2000 panjf2000 removed the stale label Nov 26, 2024
@ruimya
Copy link

ruimya commented Dec 9, 2024

@panjf2000 Has gnet considered which version will officially support TLS? Additionally, is there a way to minimize intrusion into TLS source code and avoid maintaining another set of TLS source code? Can we simply call non blocking code from the crypto/tls and rewrite the blocking code in gnet? just immature suggestion

@panjf2000
Copy link
Owner

Sorry, I can't give you a specific ETA for gnet TLS. It's not a trivial job, I don't have much time for that, also I don't have the urge to use TLS on gnet cuz the major companies that are currently using gnet employ TLS in API gateway, thus gnet itself doesn't need it. If somebody wants to implement TLS for gnet, I'd love to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed long term It's going to be a long-term work proposal Proposal for this repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants