Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 8.x checks a parameter of the action #8

Open
pwtyler opened this issue Mar 26, 2024 · 3 comments
Open

Make 8.x checks a parameter of the action #8

pwtyler opened this issue Mar 26, 2024 · 3 comments

Comments

@pwtyler
Copy link
Member

pwtyler commented Mar 26, 2024

Instead of using an @dev branch whose only difference is using an unreleased version of the upstream, make the option for 8.x checks an input parameter of running the action

@benoitchantre
Copy link
Contributor

I don’t understand why the test-versions defaults to 8.0-, but you need to use the @dev branch to benefit from appropriate dependencies.

@pwtyler What would be the downsides to merge the develop branch to main?

@pwtyler
Copy link
Member Author

pwtyler commented Mar 26, 2024

I assume @kporras07's intention was to not have the "stable" branch of the action point to an unstable version of the PHPCompatibility project, but since we're at 4+ years since a release, it's likely the right choice to just default to using the develop branch of PHPCompatibility.

@kporras07
Copy link
Collaborator

Yeah, also I think I initially didn't notice that you needed dev to get those versions. I'm happy with the decision that @pwtyler makes here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants