[DEVX-3831] Update for compatibility with PHP 8.4

[pwtyler]

Platform

(x) MacOS

Installed Via

(x) Homebrew

PHP Version

(x) 8.4.1

Terminus Version

3.6.0

Command Executed

Any

Expected behavior

No more deprecated warnings with our glorious PHP 8.4 future.

Actual behavior

PHP Deprecated:  Consolidation\AnnotatedCommand\State\StateHelper::injectIntoCallbackObject(): Implicitly marking parameter $output as nullable is deprecated, the explicit nullable type must be used instead in phar:///opt/homebrew/Cellar/terminus/3.6.0/bin/terminus/vendor/consolidation/annotated-command/src/State/StateHelper.php on line 20

Deprecated: Consolidation\AnnotatedCommand\State\StateHelper::injectIntoCallbackObject(): Implicitly marking parameter $output as nullable is deprecated, the explicit nullable type must be used instead in phar:///opt/homebrew/Cellar/terminus/3.6.0/bin/terminus/vendor/consolidation/annotated-command/src/State/StateHelper.php on line 20
PHP Deprecated:  Consolidation\AnnotatedCommand\State\StateHelper::inject(): Implicitly marking parameter $output as nullable is deprecated, the explicit nullable type must be used instead in phar:///opt/homebrew/Cellar/terminus/3.6.0/bin/terminus/vendor/consolidation/annotated-command/src/State/StateHelper.php on line 32

Deprecated: Consolidation\AnnotatedCommand\State\StateHelper::inject(): Implicitly marking parameter $output as nullable is deprecated, the explicit nullable type must be used instead in phar:///opt/homebrew/Cellar/terminus/3.6.0/bin/terminus/vendor/consolidation/annotated-command/src/State/StateHelper.php on line 32

[Farnoosh63]

Following this as I am seeing the same error

[Farnoosh63]

For now, I added:
export TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP=true
to my bash profile

[pwtyler]

Looks like this was already addressed upstream consolidation/annotated-command#311 but needs a new release (and I suppose does that necessitate a robo update?) we can then upgrade to in Terminus.

cc @greg-1-anderson

[markmont]

I'm following this issue since PHP 8.4 has started breaking things for us / our users / customers. Right now we're telling affected people to downgrade to PHP 8.3 in order to use Terminus.

I see this got tagged as v4.0... is there any guess as to when v4.0 might be released?

[pwtyler]

is there any guess as to when v4.0 might be released?

8.4 support means dropping support for older PHP versions (which the platform still supports), so we're trying not to rush it, we'll be figuring out a development/release plan next month, including making sure we capture any other breaking changes we wish to include at the same time.

[kmonty]

@pwtyler Is there a compelling reason to not release v4 but still continuing to support v3 while older versions of PHP are still supported by the platform?

[pwtyler]

Is there a compelling reason to not release v4 but still continuing to support v3 while older versions of PHP are still supported by the platform?

I expect it will look something like that. It's mostly planning and making sure we capture any other breaking changes we want to make at the same time.